Instabug-React-Native
Instabug-React-Native copied to clipboard
Change Directory Structure
Description of the change
Introduce a new directory structure that's less polluted, and groups related files together:
.
├── example/ # Previously InstabugSample
├── src/
│ ├── models/
│ ├── modules/
│ ├── utils/
│ ├── index.d.ts
│ └── index.js
├── tests/
│ ├── jest/
│ └── *.spec.js
└── ...
Type of change
- [ ] Bug fix (non-breaking change that fixes an issue)
- [ ] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Related issues
Issue links go here
Checklists
Development
- [ ] Lint rules pass locally
- [ ] The code changed/added as part of this pull request has been covered with tests
Code review
- [ ] This pull request has a descriptive title and information useful to a reviewer
- [ ] Issue from task tracker has a link to this pull request
Codecov Report
Merging #706 (46a7aaa) into master (9596788) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #706 +/- ##
=======================================
Coverage 89.81% 89.81%
=======================================
Files 22 22
Lines 599 599
Branches 93 93
=======================================
Hits 538 538
Misses 53 53
Partials 8 8
Impacted Files | Coverage Δ | |
---|---|---|
src/index.js | 82.32% <ø> (ø) |
|
src/models/Report.js | 100.00% <ø> (ø) |
|
src/models/Trace.js | 10.00% <ø> (ø) |
|
src/modules/APM.js | 89.28% <ø> (ø) |
|
src/modules/BugReporting.js | 95.91% <ø> (ø) |
|
src/modules/CrashReporting.js | 100.00% <ø> (ø) |
|
src/modules/FeatureRequests.js | 100.00% <ø> (ø) |
|
src/modules/NetworkLogger.js | 93.02% <ø> (ø) |
|
src/modules/Replies.js | 100.00% <ø> (ø) |
|
src/modules/Surveys.js | 100.00% <ø> (ø) |
|
... and 12 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Renaming InstabugSample
to example
will affect #779, should we move that change there maybe?
Renaming
InstabugSample
toexample
will affect #779, should we move that change there maybe?
@a7med-mahmoud I think we will just stick with rebase after one gets merged, it should be straight forward.
Renaming
InstabugSample
toexample
will affect #779, should we move that change there maybe?@a7med-mahmoud I think we will just stick with rebase after one gets merged, it should be straight forward.
@TheBuggedYRN Are you sure that rebasing will resolve file structure changes?
Renaming
InstabugSample
toexample
will affect #779, should we move that change there maybe?@a7med-mahmoud I think we will just stick with rebase after one gets merged, it should be straight forward.
@TheBuggedYRN Are you sure that rebasing will resolve file structure changes?
@a7med-mahmoud It will, with some manual effort.