Instabug-React-Native icon indicating copy to clipboard operation
Instabug-React-Native copied to clipboard

[MOB-9326] Use `ArgsRegistry` as SSOT

Open TheBuggedYRN opened this issue 2 years ago • 1 comments

Description of the change

Android

  • Use a more type-safe implementation instead of getDeserializedValue and getRawValue.
  • Centralize the constant conversion logic in one place, instead of the scattered methods and implementations.
  • Reduce the complexity and boilerplate of adding new constant.

iOS

  • Centralize constants values in ArgsRegistry, instead of defining it in both constantsToExport and RCTConvert.

Type of change

  • [ ] Bug fix (non-breaking change that fixes an issue)
  • [ ] New feature (non-breaking change that adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • [ ] Lint rules pass locally
  • [ ] The code changed/added as part of this pull request has been covered with tests

Code review

  • [ ] This pull request has a descriptive title and information useful to a reviewer
  • [ ] Issue from task tracker has a link to this pull request

TheBuggedYRN avatar May 11 '22 13:05 TheBuggedYRN

1 Warning
:warning: You have not included a CHANGELOG entry!
You can find it at CHANGELOG.md.

Generated by :no_entry_sign: Danger

InstabugCI avatar May 12 '22 12:05 InstabugCI

Codecov Report

Merging #699 (dd080fb) into master (cce2b25) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #699   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files          22       22           
  Lines         599      599           
  Branches       93       93           
=======================================
  Hits          538      538           
  Misses         53       53           
  Partials        8        8           
Impacted Files Coverage Δ
index.js 82.32% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 24 '22 14:08 codecov[bot]