Instabug-React-Native
Instabug-React-Native copied to clipboard
[MOB-9326] Use `ArgsRegistry` as SSOT
Description of the change
Android
- Use a more type-safe implementation instead of
getDeserializedValue
andgetRawValue
. - Centralize the constant conversion logic in one place, instead of the scattered methods and implementations.
- Reduce the complexity and boilerplate of adding new constant.
iOS
- Centralize constants values in
ArgsRegistry
, instead of defining it in bothconstantsToExport
andRCTConvert
.
Type of change
- [ ] Bug fix (non-breaking change that fixes an issue)
- [ ] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Related issues
Issue links go here
Checklists
Development
- [ ] Lint rules pass locally
- [ ] The code changed/added as part of this pull request has been covered with tests
Code review
- [ ] This pull request has a descriptive title and information useful to a reviewer
- [ ] Issue from task tracker has a link to this pull request
1 Warning | |
---|---|
:warning: | You have not included a CHANGELOG entry! You can find it at CHANGELOG.md. |
Generated by :no_entry_sign: Danger
Codecov Report
Merging #699 (dd080fb) into master (cce2b25) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #699 +/- ##
=======================================
Coverage 89.81% 89.81%
=======================================
Files 22 22
Lines 599 599
Branches 93 93
=======================================
Hits 538 538
Misses 53 53
Partials 8 8
Impacted Files | Coverage Δ | |
---|---|---|
index.js | 82.32% <ø> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more