Instabug-React-Native icon indicating copy to clipboard operation
Instabug-React-Native copied to clipboard

Published 20 hours ago • verified publisher icon Instabug

fix: use correct string type in network diagnostics handler

Open a7medev opened this issue 11 months ago • 1 comments

Description of the change

The type of the data parameter in NetworkDiagnosticsHandler was set to String which is the object wrapper around the string type, this causes TypeScript errors when trying to assign data to a variable of type string. So we changed it to string.

Type of change

  • [x] Bug fix (non-breaking change that fixes an issue)
  • [ ] New feature (non-breaking change that adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: INSD-11050

Checklists

Development

  • [ ] Lint rules pass locally
  • [ ] The code changed/added as part of this pull request has been covered with tests

Code review

  • [ ] This pull request has a descriptive title and information useful to a reviewer
  • [ ] Issue from task tracker has a link to this pull request

a7medev avatar Mar 01 '24 13:03 a7medev

Warnings
:warning:

You have not included a CHANGELOG entry! You can find it at CHANGELOG.md.

Coverage Report

Label Coverage Status
JavaScript 96.3% ✅
Android 46.9% ✅
iOS 42.2% ✅

Generated by :no_entry_sign: dangerJS against ffa2a68f6072cac9f24f2f587a4e151a575b2e90

InstabugCI avatar Mar 01 '24 13:03 InstabugCI