InsightSoftwareConsortium
ENH: Revive ExtractContoursFromImage as SimpleContourExtractor
The example was commented out since the initial import commit:
ENH: Adding media wiki examples to sphinx examples (a82f59e7ef3b9e54961bc403f9198cb6c98d35f9)
Name conflict.
Written on cellphone, excuse my brevity.
On Mon, Nov 11, 2024, 17:33 Jon Haitz Legarreta Gorroño < @.***> wrote:
@.**** commented on this pull request.
What is the reason to rename the example? Isn't ExtractContoursFromImage more meaningful that SimpleContourExtractor?
— Reply to this email directly, view it on GitHub https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/pull/432#pullrequestreview-2428275056, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANVQ6OZWJOUIIYJOWMGGVL2AEWFFAVCNFSM6AAAAABRSFCYVSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMRYGI3TKMBVGY . You are receiving this because you authored the thread.Message ID: <InsightSoftwareConsortium/ITKSphinxExamples/pull/432/review/2428275056@ github.com>
Then there is maybe some more work to do to distinguish/document better the existing and the revived examples: https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/blob/master/src/Filtering/Path/ExtractContoursFromImage/Documentation.rst vs https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/blob/77eb9d83dbbdc2a181d2b9de9ee5bda03d2b9f3e/src/Filtering/ImageFeature/SimpleContourExtractor/Documentation.rst
The revived rst file says that it is unfinished.
