ITKSphinxExamples icon indicating copy to clipboard operation
ITKSphinxExamples copied to clipboard
verified publisher icon InsightSoftwareConsortium

ENH: Adding python sample for ConvolveImageWithKernel

Open PranjalSahu opened this issue 3 years ago • 3 comments

PranjalSahu avatar May 20 '22 18:05 PranjalSahu

Hi @PranjalSahu , Could you please rebase on master -- there were package improvements unrelated to your patch that may be causing issues in CI.

thewtex avatar May 23 '22 17:05 thewtex

It is failing due to automatically generated test for baseline comparison between C++ and Python ConvolveImageWithKernelTestBaselineComparisonPython.

PranjalSahu avatar May 23 '22 18:05 PranjalSahu

Ah right, I've also run into issues with C++/Python baseline comparisons before. The ITKSphinxExamples macros were set up with the assumption that C++ and Python script output should always be the same and therefore use the same baseline image; as you've demonstrated here, there are exceptions to this rule.

Some possible paths forward:

  1. Explicitly port the C++ sample to Python, using the exact same data and image pipeline, so that the result is the same
  2. Disable the baseline comparison for now
  3. Move the Python sample to a new example with a PYTHON_ONLY baseline check
  4. Modify the CMake baseline macro so that different baselines can be explicitly provided for C++ and Python examples at the user's discretion

tbirdso avatar May 23 '22 18:05 tbirdso