ITKSphinxExamples icon indicating copy to clipboard operation
ITKSphinxExamples copied to clipboard

ENH: Migrate example itkGrayscaleFunctionDilateImageFilter

Open jadh4v opened this issue 3 years ago • 9 comments

Migrate the itkGrayscaleFunctionDilateImageFilter.cxx example from ITK/Examples/Filtering to ITKSphinxExamples/src/Filtering/MathematicalMorphology/DilateAGrayscaleImage. New baseline output image added as OutputBaseline.png as it didn't exist in ITK before.

Input Output/Baseline
cthead1 Output

The baseline output image for testing was added to Girder (data.kitware.com) in a personal public folder here: https://data.kitware.com/#item/6287b8184acac99f42cf8abb

Partially addresses https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/issues/371

jadh4v avatar May 20 '22 16:05 jadh4v

This is in draft mode, I want to add an equivalent python code as well.

jadh4v avatar May 20 '22 16:05 jadh4v

This is in draft mode, I want to add an equivalent python code as well.

Python Wrapping for module BinaryBallStructuringElement is missing. After a discussion with @tbirdso , I have decided to add the python example as a separate PR which can be merged and released later.

jadh4v avatar May 20 '22 17:05 jadh4v

@jadh4v Would you be willing to add the wrappings for BinaryBallStructuringElement to ITK? A file named BinaryBallStructuringElement.wrap would need to be added to this folder with contents similar to line 2 in https://github.com/InsightSoftwareConsortium/ITK/blob/23da3dfa79152648f3d38050ee147df47f41ce0a/Modules/Filtering/MathematicalMorphology/wrapping/itkFlatStructuringElement.wrap#L2.

tbirdso avatar May 20 '22 17:05 tbirdso

@jadh4v Please run clang-format on Code.cxx to fix Lint CI

tbirdso avatar May 20 '22 17:05 tbirdso

@jadh4v Please run clang-format on Code.cxx to fix Lint CI

Done. Also added the python code and added it to documentation.

jadh4v avatar May 20 '22 19:05 jadh4v

@tbirdso please re-run the pipeline now. I fixed the linting for python too.

jadh4v avatar May 20 '22 20:05 jadh4v

@jadh4v Two documentation warnings via CDash:

ITKEx-build/src/Filtering/MathematicalMorphology/DilateUsingFunctionalGrayscale/Documentation.rst:4: WARNING: Title underline too short.

Resolution: Extend the title underline in DilateUsingFunctionalGrayscale/Documentation.rst to at least the width of the title string

checking consistency... /.../bld/ITKEx-build/src/Filtering/MathematicalMorphology/DilateUsingFunctionalGrayscale/Documentation.rst: WARNING: document isn't included in any toctree

Resolution: Please add a reference to DilateUsingFunctionalGrayscale/Documentation.rst in https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/blob/master/src/Filtering/MathematicalMorphology/index.rst.

tbirdso avatar May 22 '22 14:05 tbirdso

Hi @jadh4v , Could you please rebase on master -- there were package improvements unrelated to your patch that may be causing issues in CI.

thewtex avatar May 23 '22 16:05 thewtex

I am going to resurrect this PR and see if we can merge this soon.

jadh4v avatar Jan 23 '25 15:01 jadh4v