ITKSphinxExamples icon indicating copy to clipboard operation
ITKSphinxExamples copied to clipboard

geodesic notebook

Open thewtex opened this issue 4 years ago • 7 comments

  • STYLE: GeodesicActiveContour CMake style
  • DOC: Add notebook example for SegmentWithGeodesicActiveContourLevelSet

thewtex avatar May 14 '21 22:05 thewtex

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Is there an already existing example of how a Jupyter notebook looks like when rendered in sphinx examples?

dzenanz avatar May 14 '21 22:05 dzenanz

Is there an already existing example of how a Jupyter notebook looks like when rendered in sphinx examples?

https://itk.org/ITKExamples/src/Registration/Metricsv4/RegisterTwoPointSets/Documentation.html

thewtex avatar May 14 '21 22:05 thewtex

A minor comment: maybe the Jupyter notebook execution-related cell data (e.g. execution_count) can be cleared before merging? Not sure if this has been in other notebooks. nbconvert can do this automatically if I'm not mistaken,

jupyter nbconvert --ClearOutputPreprocessor.enabled=True --clear-output *.ipynb

but it would also clear the output images, if any, I think. Maybe the SimpleITK folks know better how to do this.

At term, maybe having a pre-commit hook taking care of this cleaning could be handy.

jhlegarreta avatar May 14 '21 23:05 jhlegarreta

@jhlegarreta good ideas.

I will remove the cell output for this notebook, but we will likely want to add it back in the future when itkwidgets saves a more meaningful visualization. Our other notebooks have matplotlib output, which is useful to have saved in the notebook output when browsing on GitHub or nbviewer.

thewtex avatar May 17 '21 19:05 thewtex

Looks great! Notebook is helpful for following each step.

tbirdso avatar May 18 '21 16:05 tbirdso

@thewtex This would need to be rebased before considering again.

hjmjohnson avatar Nov 25 '24 15:11 hjmjohnson