ITKMinimalPathExtraction icon indicating copy to clipboard operation
ITKMinimalPathExtraction copied to clipboard

Consolidate interpolator

Open thewtex opened this issue 4 years ago • 7 comments

thewtex avatar Nov 14 '19 18:11 thewtex

Rebased

thewtex avatar Nov 14 '19 18:11 thewtex

@romangrothausmann great! Yes, please go ahead and force-push.

thewtex avatar Mar 27 '20 02:03 thewtex

Tested this with the same CLI and get the same results as with the implementation provided by @richardbeare for #61: https://gitlab.com/romangrothausmann/ITK-CLIs/pipelines/130368269

romangrothausmann avatar Mar 27 '20 18:03 romangrothausmann

@romangrothausmann awesome!

@richardbeare would be wonderful to get your review.

thewtex avatar Mar 27 '20 20:03 thewtex

On the to-do list

richardbeare avatar Mar 28 '20 01:03 richardbeare

It looks like some test baselines need to be updated and other tests are not generating baselines.

@romangrothausmann do all tests pass locally?

thewtex avatar Apr 06 '20 18:04 thewtex

It looks like some test baselines need to be updated and other tests are not generating baselines.

@romangrothausmann do all tests pass locally?

Sorry, only tested with my CLIs and the expected results, I guess the tests need to be updated to new standards of ITK-5 as well.

romangrothausmann avatar Apr 28 '20 14:04 romangrothausmann