ITK icon indicating copy to clipboard operation
ITK copied to clipboard

Published 20 hours ago • verified publisher icon InsightSoftwareConsortium

COMP: Fix for gcc13.2 compiler test failures

Open hjmjohnson opened this issue 2 months ago • 4 comments

Three tests fail in ITK for Release and RelWithDebInfo builds on Ubuntu 24.04 with GCC 13.2: itkGDCMLegacyMultiFrameTest (Failed) itkGDCMImageReadWriteTest_MultiFrameMRIZSpacing (Failed) itkGDCM_ComplianceTest_singlebit (Failed)

(Note: Debug builds do not fail these tests)

The initial review of the code did not indicate a problem, but it looks like perhaps an over-optimization that removes variables and causes the incorrect behavior to occur.

The function "FindDataElement" had duplicate code from "GetDataElement" so made "FindDataElement" use the "GetDataElement" working function.

PR Checklist

  • [x] No API changes were made (or the changes have been approved)
  • [x] No major design changes were made (or the changes have been approved)
  • [x] Added test (or behavior not changed)

hjmjohnson avatar May 02 '24 15:05 hjmjohnson