WIP: Fix for wrong cell type when LINE and POLY_LINE present

[PranjalSahu]

PR Checklist

• [ ] No API changes were made (or the changes have been approved)
• [ ] No major design changes were made (or the changes have been approved)
• [ ] Added test (or behavior not changed)
• [ ] Updated API documentation (or API not changed)
• [ ] Added license to new files (if any)
• [ ] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
• [ ] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for further development details if necessary.

[PranjalSahu]

@jhlegarreta Yes, I am adding those. It fails for the existing test mesh when writing in binary format. Also, the test mesh has pixel data that needs to be corrected. For color scalar data in binary mode writing, we convert to uchar which is making the current data value from 0.51 to 0. That data value has to be made uint8.

I assigned the value to cellType variable which permanently modified it for the rest of the loop.

[jhlegarreta]

@jhlegarreta Yes, I am adding those. It fails for the existing test mesh when writing in binary format. Also, the test mesh has pixel data that needs to be corrected. For color scalar data in binary mode writing, we convert to uchar which is making the current data value from 0.51 to 0. That data value has to be made uint8.

I assigned the value to cellType variable which permanently modified it for the rest of the loop.

Thanks Pranjal. So maybe that explains why I many of the tests for the mesh IO classes were not working as expected, and I ended up by commenting those lines: https://github.com/InsightSoftwareConsortium/ITK/pull/3403#issuecomment-1141132531

Would be great if this was the fix that made those work.

[PranjalSahu]

@jhlegarreta I am also testing the commented test cases. Some failures should not happen like a change in the number of points.

[jhlegarreta]

On a slightly related note, maybe the Valgrind issues that were uncovered by some of the mentioned tests are related to this too: https://open.cdash.org/viewDynamicAnalysis.php?buildid=8084453

[PranjalSahu]

ghostflow-check-master is stuck. I have re-pushed now.

[dzenanz]

@bradking @mathstuf do you have some advice regarding ghostflow here? It is obviously misbehaving.

[mathstuf]

Do: check