ITK icon indicating copy to clipboard operation
ITK copied to clipboard

Integrate some remote modules into ITK proper

Open dzenanz opened this issue 2 years ago • 9 comments

Some remote modules have been in use for a long time, and should be integrated into the main repository (i.e. https://github.com/InsightSoftwareConsortium/ITK/). Some examples are https://github.com/InsightSoftwareConsortium/ITKSplitComponents/issues/50 and https://github.com/InsightSoftwareConsortium/ITKFastBilateral/issues/2.

I think there are more, and we should review the complete list. Better candidates are the remote modules with just one or two filters.

Then there are some rarely used/unused ones, such as https://github.com/KitwareMedical/MultipleImageIterator. I think we should deprecate that one, and schedule it for removal in ITK6. Are there any more?

dzenanz avatar Apr 12 '22 16:04 dzenanz

It would be appreciated if there are any volunteers for helping with this.

dzenanz avatar Apr 12 '22 16:04 dzenanz

I would also vote for putting effort into the following to get them upto quality levels where they can be included in the toolkit:

AdaptiveDenoising AnisotropicDiffusionLBR GenericLabelInterpolator

MGHIO <--- On the fence about this one.

hjmjohnson avatar Apr 12 '22 16:04 hjmjohnson

I thought that maintenance of MGHIO was shared with Slicer, and therefore isn't a good candidate for integration?

dzenanz avatar Apr 12 '22 16:04 dzenanz

Slicer now uses MGHIO directly as an ITK remote module. Maintenance is done as an ITK remote module. I would think that adding it directly to the main repo would simplify the efforts of maintaining the codebase.

hjmjohnson avatar Apr 12 '22 16:04 hjmjohnson

OK. It also doesn't have a lot of files, so it should be simple from that point of view.

I guess we could/should use a merge style which preserves file history for all the remotes we decide to merge.

dzenanz avatar Apr 12 '22 17:04 dzenanz

I would offer to help merge ITKLabelErodeDilate into ITK proper (if you agree it is a good candidate). Some instructions would be appreciated.

dyollb avatar Jun 04 '22 21:06 dyollb

@dyollb maybe wait until we integrate one or two remotes in order to see how to do it.

dzenanz avatar Jun 06 '22 08:06 dzenanz