ITK icon indicating copy to clipboard operation
ITK copied to clipboard

WIP: Test resampling with Gauss interpolator when employing streaming

Open romangrothausmann opened this issue 6 years ago • 12 comments

Test program to test resampling with Gauss interpolator when employing streaming, in conjuction to #1011 and #998.

PR Checklist

romangrothausmann avatar Jun 12 '19 15:06 romangrothausmann

Since all tests succeed, it seem that just using GaussianInterpolateImageFunction with a test based on itkResampleImageTest7 does not seem to trigger the problem of #1011. I also tried using 3D data instead of 2D, but then the test fails already without using GaussianInterpolateImageFunction probably due to the fixed tests concerning the chunk sizes. @thewtex How did you come up with these values: https://github.com/InsightSoftwareConsortium/ITK/blob/0b588250b03da219463e6417ddf6e6d3746e8696/Modules/Filtering/ImageGrid/test/itkResampleImageTest7.cxx#L135-L137

romangrothausmann avatar Jun 12 '19 19:06 romangrothausmann

@romangrothausmann examining what the actual values are? The GetRadius patch has increased the region by 1 pixel on all sides.

dzenanz avatar Jun 12 '19 20:06 dzenanz

Errors:

  • Failed to run the checks: service error.

kwrobot-v1[bot] avatar Jun 14 '19 10:06 kwrobot-v1[bot]

examining what the actual values are?

@dzenanz What do you mean by that? The increase in the reagion is clear but how to get those values for a 3D case as e.g. in: https://github.com/InsightSoftwareConsortium/ITK/pull/1012/commits/3f5fd25b46d2b96cdf1122db959f9321ae8c56c6 And why does the test succeed even for GaussianInterpolateImageFunction (where the radius should be larger)?

romangrothausmann avatar Jun 14 '19 10:06 romangrothausmann

examining what the actual values are?

Run the program under debugger and examine the values.

GaussianInterpolateImageFunction's radius depends on the sigma parameter. I guess the default sigma results in radius of 1, which is the same as linear interpolation.

dzenanz avatar Jun 14 '19 13:06 dzenanz

This PR should be revived after #1191 and #1213 are merged.

dzenanz avatar Aug 29 '19 15:08 dzenanz

@romangrothausmann can you rebase this PR on current master?

dzenanz avatar Oct 22 '19 14:10 dzenanz

That should be possible, I'll give it a try.

romangrothausmann avatar Oct 22 '19 14:10 romangrothausmann

3D version without GaussianInterpolateImageFunction (https://github.com/InsightSoftwareConsortium/ITK/pull/1012/commits/26c91e7a042e52dc0a701046652486b65b7102cb) now works for me locally. Let's see if it still does with GaussianInterpolateImageFunction.

romangrothausmann avatar Oct 22 '19 16:10 romangrothausmann

Oddly, on my local PC ctest -R ResampleImageTest8 passes even though I would expect that it fails with only the changes of https://github.com/InsightSoftwareConsortium/ITK/pull/1012/commits/452bba143180952b5f27dc05690863b9315f75fa because I would expect that the 3rd dimension would demand changes to https://github.com/InsightSoftwareConsortium/ITK/blob/452bba143180952b5f27dc05690863b9315f75fa/Modules/Filtering/ImageGrid/test/itkResampleImageTest8.cxx#L133-L138 @dzenanz How to "Run the program under debugger" with ctest?

romangrothausmann avatar Oct 23 '19 09:10 romangrothausmann

ctest -VV will print the exact command line for each test. That way, you can run that command line under debugger (e.g. copy command-line parameters into Visual Studio).

dzenanz avatar Oct 24 '19 13:10 dzenanz

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

stale[bot] avatar Feb 21 '20 13:02 stale[bot]