koin
koin copied to clipboard
Documentation Bug: "Application" Should Be "Activity"
Describe the bug The wrong class is used in a code snippet in the documentation.
To Reproduce Steps to reproduce the behavior:
- Go to https://insert-koin.io/docs/setup/why#ready-for-android
- Read the second code snippet, notice that the class is named
MyActivityand that injected object is a "presenter"
Expected behavior
MyActivity to extend Activity, not Application. IOW, it should be:
class MyActivity : Activity() {
val myPresenter : MyPresenter by inject()
}
(if you would prefer ComponentActivity or AppCompatActivity, that's cool too)
Koin module and version:
The current version of Koin is 4.0.0-RC1
Thanks for considering this!