Koin module verification fails

[MolchanovDmitry]

Describe the bug

1. Koin module verification fails when initialize class in definition block.
2. For CompositeDisposable dependency should add following extra types:

listOf(
    Iterable::class,
    Array<Disposable>::class,
)

To Reproduce Steps to reproduce the behavior:

1. Create android project
2. Add rxJava2 dep io.reactivex.rxjava2:rxjava:2.2.8
3. Create koin module with CompositeDisposable dependency
4. Initialize some class in definition block.

Expected behavior Test passes without adding additional extra types

Koin module and version: koin-android:3.5.6 koin-test:3.5.6

Snippet or Sample project to help reproduce

AppModule.kt

import io.reactivex.disposables.CompositeDisposable
import org.koin.dsl.module

class A
class B(val compositeDisposable: CompositeDisposable, val a: A)

val appModule = module {

    single { CompositeDisposable() }

    single { B(get(), A()) }
}

KoinVerificationTest.kt

class KoinVerificationTest {

    /** uncomment extra types for test pass */
    @Test
    fun `koin verification test`(){
        appModule.verify(extraTypes = listOf(
            //A::class,
            //Iterable::class,
            //Array<Disposable>::class,
        ))
    }
}

[arnaudgiuliani]

in your case, class A is missing?

[jun-tomioka]

Hi team 👋 Any updates on this?

We can reproduce this issue by simply put this.

data class A(val b: B)
data class B(val value: Int)

module {
  single { A(B(1)) }
}.verify() // this would fail because it tries to look up B instance based on A's constructor.

I think the problem here is it looks up the dependency from A's constructor even though A's factory is explicitly given - which doesn't make sense.

checkModule was covering this case, but now it's deprecated.

[lsrom]

I seem to have this or similar problem as well. In my case, I have multi module (Kotlin MP) project where one module has ClassA defined as singleton. Calling verifyAll() or verify() fails with message that ClassA is missing while checkModules works fine. Obviously running the project works as well, the modules are correct. Not sure how is verify different from checkModules but it seems to me that checkModules was deprecated too early.

[arnaudgiuliani]

Yeah, Verify works on static type. It won't see easily things behind a lambda. CheckModules was interesting but hard to maintain on the long :/

This point here is about default value. This could be a point 🤔

[MAX-POLKOVNIK]

@arnaudgiuliani Hi. I'm not sure if my issue related to this but it seems very similar.

I have this definition in android module:

single<AccountManager> { AccountManager.get(androidContext()) }

and verification fails:

* ----- > Missing definition for '[field:'arg1' - type:'android.accounts.IAccountManager']' in definition '[Singleton: 'android.accounts.AccountManager',binds:android.accounts.AccountManager]'.
- Fix your Koin configuration -
1- add missing definition for type 'android.accounts.IAccountManager'. like: singleOf(::android.accounts.IAccountManager)
or
2- else define injection for 'android.accounts.AccountManager' with:
module.verify(
    injections = injectedParameters(
        definition<android.accounts.AccountManager>(android.accounts.IAccountManager::class)
    )
)

But I can't add android.accounts.IAccountManager::class because it is internal in android

How can I bypass this error?

[arnaudgiuliani]

You can work by whitelisting the needed type: verify(extraTypes: List<KClass<*>> = emptyList(), injections: List<ParameterTypeInjection>? = emptyList())

You can declare it as extraTypes

[MAX-POLKOVNIK]

You can work by whitelisting the needed type: verify(extraTypes: List<KClass<*>> = emptyList(), injections: List<ParameterTypeInjection>? = emptyList())

You can declare it as extraTypes

Thanks! I have to retrieve KClass via reflection like this: Class.forName("android.accounts.IAccountManager").kotlin Luckily I do not have same situation with internals on iOS 'cause we do not have same ability in Kotlin/Native

[TingGu-Tyro]

I fix it by:

definition<CompositeDisposable>(Array<Disposable>::class, Iterable::class)

[arnaudgiuliani]

👍