Austin Henriksen
Austin Henriksen
We used to indent our Java code with 4 spaces, but when we added the spotless formatting plugin to our build, it switched to 2 spaces, since it's using `googleJavaFormat`,...
This PR implements #2093. After I centralized all the deprecation checking to the Parser, only these 2 functions need to be changed. Let me know if the logic for `isDeprecated`...
Due to our non-existent metadata validation, the Slice compiler allows you to put `["deprecate"]` on pretty much anything. But, what this _actually_ affects is very language dependent, and I think...
In the "Ice 4.0" days, we replaced the `optional` keyword to `tag`, but kept `optional` for backwards compatibility. We kept separate tokens for them so we could emit deprecation warnings...
This PR adds a check to the Slice parser which will emit an error if you mark a type as `optional` if that type uses classes. It also fixes the...
Quote: `a valid fragment contains only unreserved characters, reserved characters or '%'.` This seems pretty dubious to me. If a fragment can contain `unreserved characters` and `reserved characters`... isn't that...
We have a variety of function signatures ranging from simple `&str` to `T: ToString` to `impl Into`. We should look through our API surface and see if these types could...
In `slicec` we have an entire `tests` directory with a module of helper functions. These tests are centralized (in the `tests` directory) and then organized into categories. Whereas in `slicec-cs`...
Currently, in Java, calling `checkedCast` will always eat `FacetNotExistException`, and if caught, we return `null`: https://github.com/zeroc-ice/ice/blob/b81c856d81add8691dafe56ac51097faed13a9da/java/src/Ice/src/main/java/com/zeroc/Ice/ObjectPrx.java#L879-L880 So it's impossible for `checkedCast` to ever throw this exception, in Java. But in...
There are still 3 places where we reference it, which we should remove: 1. in `cpp/test/IceUtil/stacktrace/test.py`: We set this option: `TestSuite(__name__, options={"cpp11": [False]})` 2. in `cpp/test/Ice/scope/AllTests.cpp` We have 4 of...