Austin Henriksen
Austin Henriksen
> Should we also fix on 3.7? I don't see why not.
Ah, it'd make sense if they weren't pulling along into the new testing system then. Seems like the consensus is that we should keep these tests, update/remove their old Slice...
I've been using this option for a while under the impression that it means: "if there is only a single `where` condition, put it on one line" otherwise format it...
> Does it make sense to do so? Personally, I think it looks better without a space between the trailing comma and parenthesis. So with your example, I'd prefer it...
> I just wanted to double check Absolutely! Honestly, I hadn't even considered that edge case, so it's good you thought it up! > but if there isn't would you...
> Before I forget, I also want to say thanks for your first contribution to rustfmt Thanks! And right back at you for putting so much effort into maintaining it!...
Alsooo, while I have your attention ^-^ do you have any opinion on: https://github.com/rust-lang/rustfmt/issues/3354#issuecomment-1232915725? I pro-actively offered to fix the problem he was describing, but after thinking about it more,...
> I think this may fix the single-line issue I mentioned in https://github.com/rust-lang/rustfmt/issues/5984, but do you know if it may also fix the multiline issue? As @ytmimi points out, my...
@ytmimi For sure! I just rebased my commits over master. I'm just too used to squash merging my PRs : v)
### Problem This seems to be caused by the intersection of 2 things: an assumption in the macro parsing code, where we always insert a 'separator' before parsing a meta-variable...