onyxia icon indicating copy to clipboard operation
onyxia copied to clipboard

highlightedCharts is mandatory, but it doesn't have to be

Open Yuwei0021 opened this issue 1 year ago • 6 comments

In the configuration of a catalog, if we don't include 'highlightedCharts', for example like this :

catalogs: [  
      {  
        "id": "ide",  
        "name": "Data fabrique",   
        "location": "REPOSITORY_HELM",  
        "status": "PROD",  
        "type": "helm",  
        "multipleServicesMode": "maxNumber",  
        "maxNumberOfVersions": 5,  
      }  
]  

When we land on the catalog page via the 'Catalogue de services' button, nothing is displayed.

Yuwei0021 avatar Oct 10 '24 10:10 Yuwei0021

Ok thank you for reporting!
I'll fix that

garronej avatar Oct 10 '24 15:10 garronej

Hey @Yuwei0021, unfortunately, i'm unable to reproduce.

I'll let @fcomte or @olevitt tell me if this is an actual issue.

garronej avatar Oct 10 '24 18:10 garronej

Hi !

I managed to reproduce on first try in a brand New instance, with a single catalog, with no (Key not present) highlightedChart. On both V8 and v9. Adding `highlightedCharts: [...]" solved the issue

olevitt avatar Oct 10 '24 18:10 olevitt

Looking at the code I can't figure out what's going on and surely if highlightedCharts I set it to an empty array...
Can you have a look at what the API sends back? Maybe it sends an empty string as value of highlightedCharts or something.

garronej avatar Oct 10 '24 19:10 garronej

Looking at the code I can't figure out what's going on and surely if highlightedCharts I set it to an empty array... Can you have a look at what the API sends back? Maybe it sends an empty string as value of highlightedCharts or something.

I will set you up an env with the bug tomorrow

olevitt avatar Oct 10 '24 19:10 olevitt

Looking at the code I can't figure out what's going on and surely if highlightedCharts I set it to an empty array... Can you have a look at what the API sends back? Maybe it sends an empty string as value of highlightedCharts or something.

I will set you up an env with the bug tomorrow

Could not reproduce today.
I swear I had the issue yesterday with the following configuration on both the latest v8 and latest v9 :

  ingress:
    enabled: true
    hosts:
      - host: <myurl>
    tls:
      - hosts:
          - <myurl>

  api:
    catalogs:
      [
        {
          id: "ide",
          name: "Interactive services",
          location: "https://inseefrlab.github.io/helm-charts-interactive-services",
          status: "PROD",
          type: "helm"
        }
      ]

olevitt avatar Oct 11 '24 13:10 olevitt