onyxia icon indicating copy to clipboard operation
onyxia copied to clipboard

refactor MyFilesMySecrets into 2 explorer

Open ddecrulle opened this issue 2 years ago • 1 comments

ddecrulle avatar Oct 16 '22 19:10 ddecrulle

LGTM at a glance but I can't guarenty everything's alright without redoing the work myself.
You can't relies on me to tell you if something wrong, you are responsible and acountable for this refactor.

For seeing you write code live, I noticed that you lack methodology when refacoring.
You simply re write the code. Then forget what was in place before. This is a very risky approach.

Please copy paste the block of code you want to edit. Comment the old version, edit the version that isn't commented. Once you are done re-writing the block you can then proceede to delete the commented one.

https://user-images.githubusercontent.com/6702424/197961552-af66602d-c4a6-474c-bd46-a4c18df4ae25.mov

If you are changing a whole file. Make a copy of the file before starting your changes.

https://user-images.githubusercontent.com/6702424/197961537-fa874c02-57fc-414f-b799-dbac56c1deff.mov

Also avoid search and replace and use "rename this token" only for types.

It's much beter to go a bit slower when refactoring than having to figure out what whent wrong retrospectively.

Thanks for your work,

garronej avatar Oct 26 '22 07:10 garronej