Inphi
Inphi
cc: @smartcontracts
No longer needed. Closing.
It'll be good to update the Portal2 post checks to further ensure that we don't accidentally reuse that slot for something else. Relying on human review for storage slot changes...
Could you provide some context? How does this fix the deadlock?
Oh I see, the short-circuit prevents the new block event from being emitted and the `SyncService.applyTransaction` waits for that event before returning. One thing to note is if the block...
Agreed. I'll check with terencechain on the status of his branch.
The tests are expected to fail atm.
The receipt of such transactions contain [DelegateChanged](https://docs.openzeppelin.com/contracts/4.x/api/governance#IVotes-DelegateChanged-address-address-address-) events. There's already logic in roseta-geth-sdk to parse [ERC20 transfer events](https://github.com/coinbase/rosetta-geth-sdk/blob/master/services/block_service.go#L117). Parsing delegate calls would be similar.
@maurelian Should be good for another review.
> Needs a new `just simulate` job added to CI. @maurelian Note that unlike SC actions, this isn't a task that will always work across upgrades. Every time we upgrade...