OpenZWave icon indicating copy to clipboard operation
OpenZWave copied to clipboard

Merge LZW31(-SN) upstream

Open uSpike opened this issue 5 years ago • 4 comments

Hi, I'd just like to request that the LZW31(-SN) configs be merged into upstream open-zwave. I'm currently testing my LZW31-SN with the config here, but I'd really like to go back to upstream configuration! Thanks!

uSpike avatar Nov 13 '19 04:11 uSpike

It looks like a PR was created in January, However @InovelliUSA has yet to address the requested review/changes for it to get merged. https://github.com/OpenZWave/open-zwave/pull/2077

mdallaire avatar Mar 03 '20 14:03 mdallaire

If someone can confirm the lzw31-sn works without the CentralScene Block in the config file, I'm happy to merge manually. Just need someone to test it out.

Fishwaldo avatar Mar 04 '20 03:03 Fishwaldo

I have a LZW31-SN with OZW 1.6 - it appears to work without the CentralScene block - it would be really nice to have LZW31-SN in the official config repository....

cts1085 avatar Mar 04 '20 16:03 cts1085

I have a LZW31-SN with OZW 1.6 - it appears to work without the CentralScene block - it would be really nice to have LZW31-SN in the official config repository....

I just tested this too and detailed my results here: https://github.com/OpenZWave/open-zwave/pull/2077#issuecomment-594653395 @Fishwaldo I think you can merge manually but let me know if you want more testing.

mdallaire avatar Mar 04 '20 16:03 mdallaire