GPCS4 icon indicating copy to clipboard operation
GPCS4 copied to clipboard

Build Issue

Open danni551 opened this issue 3 years ago • 11 comments

I get an error when i try to build it

In file included from arch\x86\x86_helpers.cpp:18: 1>In file included from arch\x86/x86_helpers.h:21: 1>C:\Users\danie\Downloads\GPCS4-0.2.2\3rdParty\xbyak\xbyak.h(16,6): error : invalid token at start of a preprocessor expression 1>Die Erstellung des Projekts "TinyDBR.vcxproj" ist abgeschlossen -- ERROR

danni551 avatar Jun 22 '22 18:06 danni551

I remember this is a known issue What's the version of clang are you using?

Inori avatar Jun 23 '22 03:06 Inori

yupp same error here too and it was on 13.0.0 and 14.0.4, also tried an old 9.0.0

Brutal-sam avatar Jun 23 '22 04:06 Brutal-sam

@Brutal-sam @danni551 I remember the problem solved when I updated my clang version (not 100% sure though). How do you change your clang version? I used this config file.

Inori avatar Jun 23 '22 08:06 Inori

tried using the config file to change to different versions of clang but the same issue remains, maybe it's not a clang version issue. we know it's not meant for the end user yet but reporting those issues can be helpful to you as a dev

Brutal-sam avatar Jun 24 '22 17:06 Brutal-sam

It seems it's because clang doesn't recognize not token, but I don't know why I can compile on all of my machines (tested on 3 machines). You can try to comment out those 3 lines, it should be safe.

Inori avatar Jun 24 '22 18:06 Inori

commenting out the 3 lines just created more errors, like memory_order_relaxed is not defined, and function call not allowed. but it's all good now I sent this to my dev friend and he built it for me so I have it running samples now, hope you fix the support for We Are Doomed or something else.

1 Capture

Brutal-sam avatar Jun 26 '22 02:06 Brutal-sam

@Brutal-sam memory_order_relaxed issue should have been fixed in more recent code base. I haven't met function call not allowed issue myself, seems for some reason you are not using correct compiler. What did your friend say about the compiling errors?

Inori avatar Jun 26 '22 09:06 Inori

@Inori he didn't say anything about errors but said this: "just left the default compiler of the project, maybe some missing installation here made the compiler be changed automatically", if it's okay can you share screenshots of how to change the compiler to the right one?

Brutal-sam avatar Jun 27 '22 06:06 Brutal-sam

memory_order_relaxed issue should have been fixed in more recent code base.

No, it still exist even in dev branch. IDK how you're building your project, instead of arguing just setup CI for project, all users's compiling tries will stop.

gandalfthewhite19890404 avatar Jul 21 '22 06:07 gandalfthewhite19890404

Also in your sources these files are missing #include <boost/predef/version_number.h> #include <boost/predef/hardware/simd/arm/versions.h>

gandalfthewhite19890404 avatar Jul 21 '22 06:07 gandalfthewhite19890404

Also in your sources these files are missing #include <boost/predef/version_number.h> #include <boost/predef/hardware/simd/arm/versions.h>

https://levelup.gitconnected.com/the-definite-guide-on-compiling-and-linking-boost-c-libraries-for-visual-studio-projects-c79464d7282d

xgrommx avatar Aug 10 '22 15:08 xgrommx

Using VS2022 and LLVM 16.0.6, should be all fixed.

Inori avatar Jun 20 '23 14:06 Inori