vue2-daterange-picker icon indicating copy to clipboard operation
vue2-daterange-picker copied to clipboard

Vue 3 Support

Open hisuwh opened this issue 4 years ago • 12 comments

Are there any plans to support Vue 3 with this package?

hisuwh avatar Aug 16 '21 08:08 hisuwh

well there are plans :), but I don't how to handle both versions because I dont want to make separate component for vue 3

nkostadinov avatar Sep 10 '21 11:09 nkostadinov

@nkostadinov have you seen this: https://github.com/vueuse/vue-demi

hisuwh avatar Sep 10 '21 15:09 hisuwh

@hisuwh looks like what I need, I will check it :) 10x

nkostadinov avatar Sep 10 '21 17:09 nkostadinov

Any updates on this issue? Vue 3 is the new recommended version of Vue, but there's no support still

davolcu avatar Feb 22 '22 07:02 davolcu

@nkostadinov Since I needed the daterange picker for Vue 3 asap, I have forked and upgraded your codebase to Vue 3, Vite and VuePress v2 - https://github.com/EntryPointDev/vue3-daterange-picker

All original tests are passed.

A few things to note:

  • I didn't want to use Vue-demi, so it is a separate version of component
  • JSON doc generation for components is currenly missing, as @vuedoc/parser doesn't support the Vue 3 yet

Would you be interested in PR? If so, please create a separate branch for Vue 3 version, so I could use it as a base branch when creating a PR.

ghrapan avatar Feb 23 '22 12:02 ghrapan

@nkostadinov Since I needed the daterange picker for Vue 3 asap, I have forked and upgraded your codebase to Vue 3, Vite and VuePress v2 - https://github.com/EntryPointDev/vue3-daterange-picker

All original tests are passed.

A few things to note:

  • I didn't want to use Vue-demi, so it is a separate version of component
  • JSON doc generation for components is currenly missing, as @vuedoc/parser doesn't support the Vue 3 yet

Would you be interested in PR? If so, please create a separate branch for Vue 3 version, so I could use it as a base branch when creating a PR.

@ghrapan

It works nicely! but the appendToBody doesn't seem to work.

gabstafari avatar Feb 24 '22 19:02 gabstafari

@nkostadinov Since I needed the daterange picker for Vue 3 asap, I have forked and upgraded your codebase to Vue 3, Vite and VuePress v2 - https://github.com/EntryPointDev/vue3-daterange-picker All original tests are passed. A few things to note:

  • I didn't want to use Vue-demi, so it is a separate version of component
  • JSON doc generation for components is currenly missing, as @vuedoc/parser doesn't support the Vue 3 yet

Would you be interested in PR? If so, please create a separate branch for Vue 3 version, so I could use it as a base branch when creating a PR.

@ghrapan

It works nicely! but the appendToBody doesn't seem to work.

@gabstafari Sorry, missed your PR. I've pushed a fix.

ghrapan avatar Mar 01 '22 15:03 ghrapan

Hello,

i've tried your fork and appendToBody does not seems to work :

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'appendToBody')
    at inserted (appendToBody.js?d7a7:3:1)

did you publish a new version on npm after the pull request ?

lk77 avatar Apr 19 '22 07:04 lk77

Hello,

i've tried your fork and appendToBody does not seems to work :

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'appendToBody')
    at inserted (appendToBody.js?d7a7:3:1)

did you publish a new version on npm after the pull request ?

Hello,

Yes I did, it's version 0.1.2. The error message strongly suggests that you're using the previous version.

ghrapan avatar Apr 20 '22 06:04 ghrapan

mm it's seems i installed the wrong package, https://www.npmjs.com/package/vue3-daterange-picker instead of https://www.npmjs.com/package/vue3-gabe-daterange-picker

thanks

lk77 avatar Apr 22 '22 07:04 lk77

Is there any alternative or support for vue3. Please comment

viswa1989 avatar Jun 30 '22 13:06 viswa1989

I have appreciated this library. But now for vue 3, i will switch to https://vue3datepicker.com

Note: for the preset range see

rdhainaut avatar Oct 20 '23 09:10 rdhainaut