EfCoreJsonValueConverter icon indicating copy to clipboard operation
EfCoreJsonValueConverter copied to clipboard

Support for .net standard 2.0

Open shshzi opened this issue 5 years ago • 3 comments

I was wondering why the project was upgraded to .net standard 2.1 instead of staying on 2.0? This breaks compatibility with projects that need to support .net framework.

shshzi avatar Apr 16 '20 05:04 shshzi

Might be due to stupidity of the developer :) I need to review this with better time, maybe we can go back to 2.0.

AlexEngblom avatar Apr 16 '20 18:04 AlexEngblom

I've changed in my own private fork and everything works, no incompatibilities.

On Fri, Apr 17, 2020 at 4:05 AM Alex Engblom [email protected] wrote:

Might be due to stupidity of the developer :) I need to review this with better time, maybe we can go back to 2.0.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Innofactor/EfCoreJsonValueConverter/issues/10#issuecomment-614809051, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFZEJ6VNOZGCVZ7XQGPJ5NTRM5CE7ANCNFSM4MJGYQUQ .

shshzi avatar Apr 17 '20 12:04 shshzi

+1 on this. we always coded around this by using all sorts of nasty pragma's to conditionally import the library and conditionally annotate things with the understanding that we'd only be able to use these json-stored types in newer code that leverages our shared layers. just actually had to remove this for that reason as we needed to come up with another approach so the old stuff could use those models too.

would rather add this back in if this is done, or maybe i'll fork and change it too.

mrtristan avatar Mar 16 '22 22:03 mrtristan