InnerSourcePatterns icon indicating copy to clipboard operation
InnerSourcePatterns copied to clipboard

Maturity Model: Formatting and grammar updates

Open jasonpatrickellykrause opened this issue 1 year ago • 4 comments

  • Updated headings to be heading level 4 instead of emphasizing.
  • Removed unnecessary line breaks.
  • Updated grammar and spelling.

jasonpatrickellykrause avatar May 11 '23 16:05 jasonpatrickellykrause

@jasonpatrickellykrause thanks for sending these fixes, much appreciated!

A quick question: is this file essential for this PR?

I have not worked with vscode setting files before, and we don't use them in this repo yet. So it is a bit hard for me to judge what introducing these means for all users of the repo.

Thanks again for taking the time to improve the pattern!

spier avatar May 11 '23 16:05 spier

@jasonpatrickellykrause thanks for sending these fixes, much appreciated!

A quick question: is this file essential for this PR?

I have not worked with vscode setting files before, and we don't use them in this repo yet. So it is a bit hard for me to judge what introducing these means for all users of the repo.

Thanks again for taking the time to improve the pattern!

It is not, my bad!

jasonpatrickellykrause avatar May 11 '23 16:05 jasonpatrickellykrause

Btw I don't know how gitbook (where we host the patterns for our readers) will format the H4 heading nicely. But we shall see. This is how it looks like in gitbook before this change: https://patterns.innersourcecommons.org/p/maturity-model

spier avatar May 11 '23 18:05 spier

@jasonpatrickellykrause I added the vale style/spell checker, and through that I also made some fixes in the maturity model. This unfortunately lead to some conflicts with your PR here.

Would you mind checking those, and also the comments I left inline on this PR?

spier avatar May 22 '23 21:05 spier