InnerSourcePatterns icon indicating copy to clipboard operation
InnerSourcePatterns copied to clipboard

pattern draft: Incubator Pipeline

Open gyehuda opened this issue 3 years ago • 2 comments

This is the first draft.

[Update]: Quick link to rendered markdown

gyehuda avatar Jul 19 '21 22:07 gyehuda

In the first round of review I am just making some fixes to the markdown. I will commit them straight away, as they won't be controversial.

Then I will run other CI checks (via GitHub Actions), just to confirm that there aren't any other issues with the formatting.

Once that is done, I will add some suggestions for content changes for you to review. This last step might take me a couple of days.

spier avatar Aug 07 '21 05:08 spier

@gyehuda one thought about this PR: PRs that are open for extended periods run the risk of becoming stale, and eventually unmergable. Typically because author or reviewer have moved on, or the context in which the pattern was first created has changed too much.

Another disadvantage particular to new patterns in PRs (rather than improvements of existing patterns) is, that many readers won't find these new patterns when they are hidden in PRs, as they mostly view the patterns in the main brach of our repo.

Therefore I am wondering what the smallest possible increment on this PR would be that allows us to merge it, so that the new Incubator Pipeline pattern becomes available in the main branch for everybody to read?

One proposal from me:

  • merge this branch as is but keep all review comments in this PR open. Add a link from the pattern to this PR, so that we can work in the feedback from the open comments in future improvements to this pattern.

Would that work? Or would you favor another approach?

spier avatar Dec 10 '21 20:12 spier

One proposal from me:

merge this branch as is but keep all review comments in this PR open. Add a link from the pattern to this PR, so that we can work in the feedback from the open comments in future improvements to this pattern. Would that work? Or would you favor another approach?

I'm going to action this. I can raise another PR to add some of the comments content in.

robtuley avatar Nov 24 '22 21:11 robtuley

Updates for this pattern are now continued in #489

robtuley avatar Nov 24 '22 22:11 robtuley