InnerSourceLearningPath
InnerSourceLearningPath copied to clipboard
InnerSourceCommons
Publish articles without videos
There are two articles in the introduction section that are text-only at this point. They should still be published on the website, just without a video.
You will need to run (and probably modify) generate_learning_path_markdown.js in order to complete this.
@marshmallowrobot will take a look. Reach out with any questions and updates!
Progress Update: No progress!
I had issues with the script at first, since there's something out there that doesn't have an article title, so the regex that parses it out was causing errors. I believe I have a workaround for that now.
My next issue is I'm being rate limited by the GitHub API. They only allow 5k requests per hour, and I've somehow exceeded that? ¯\(ツ)/¯. Is there some flag or setting I can use to reduce the regenerated sections of the site? or reduce the GitHub API calls while developing? If ya'll haven't run into this issue yet, please share how I can avoid it too. TY!
Glad you are working on this, @marshmallowrobot ❗ 5K requests sounds like a lot (too many). @tsadler1988 may have some idea of why you are making so many (or how to reduce it).
Are we making one API call for each language, for example? We can develop in English-only mode if that were the case.
Progress Update: Issue is technically fixed, but still aesthetically broken.
The rate limiting appears to be related to how we are fetching contributor information. The system is fetching contributor info for each article and for each language. Since I commented out that module (locally! nothing permanent), I haven't had any rate limit issues.
I added some functions around fetching of URLs to handle when data is missing. I can now see all published articles on my local copy of the website. However, the broken images are pretty ugly. Here's an example:
How would ya'll like to handle this going forwards?
- Should we use a generic thumbnail for all non-imaged articles?
- Or just take it easy and remove the image from the layouts?
@marshmallowrobot this is amazing progress!
How about just white space if no video?
Code updated in https://github.com/InnerSourceCommons/InnerSourceLearningPath/pull/502 Website formatting updated in https://github.com/InnerSourceCommons/innersourcecommons.org/pull/393
Thanks for working on this @marshmallowrobot! Screenshot looks good! I side with "white space" as @rrrutledge proposed. Of course, we could always use a an appropriately licensed and carefully curated meme / member of the creative-404-images tribe. :wink:
I'm going to close this issue, as the fix was deployed a couple of weeks ago.