sdk-go icon indicating copy to clipboard operation
sdk-go copied to clipboard

(feat) Updated core protos to the changes required by TS SDK

Open ThomasRalee opened this issue 1 year ago • 3 comments

Summary by CodeRabbit

  • New Features

    • Added min_notional field to enhance market information in Derivative and Spot Market protocols.
    • Introduced admin validation for Peggy and Exchange modules.
  • Improvements

    • Updated fee validation logic for better error reporting.
    • Simplified control flow in access control functions for WasmX module.
  • Bug Fixes

    • Corrected timestamp conversion in Oracle module to ensure accurate validation.
  • Updates

    • Adjusted listing fees to 20 INJ for Spot and Derivative markets.
    • Added new access configuration parameter in WasmX module.

ThomasRalee avatar Jul 17 '24 08:07 ThomasRalee

Walkthrough

The updates span various modules, including fee validation, market fee parameters, timestamp conversion, parameter validation, and protocol buffer enhancements. Key changes include simplified fee validation logic, adjusted listing fees, new admin validation functions, a timestamp conversion utility, and additional fields in protocol buffers for market information.

Changes

File Path Summary of Changes
chain/exchange/types/fee_validation.go Simplified fee validation logic and improved error reporting.
chain/exchange/types/params.go Reduced listing fees and added validateAdmins function.
chain/oracle/types/msgs.go Added ConvertTimestampToNanoSecond function and updated validation logic for MsgRelayStorkPrices.
chain/peggy/types/params.go, params_legacy.go Added Admins field and validation logic, updated DefaultParamspace.
chain/wasmx/types/params.go, util.go Introduced registerContractAccess parameter and validateAccessConfig function, simplified IsAllowed.
exchange/derivative_exchange_rpc/pb/... Added min_notional fields to DerivativeMarketInfo and BinaryOptionsMarketInfo messages.
exchange/spot_exchange_rpc/pb/... Added min_notional field to the SpotMarketInfo message.

Poem

In the land of code, where rabbits roam, New rules for fees, a simpler tome. Markets now list at a lower fee, Time in nanos, clear as can be. Admins validated, not a flaw in sight, Protocol buffers enhanced, markets shine bright.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jul 17 '24 08:07 coderabbitai[bot]

@ThomasRalee what is this PR for? I see that the only chages are in the compiled protos that come from injective-core and injective-indexer. But I update those compiled protos regularly in the parent branch. I don't get the need for this.

aarmoa avatar Jul 18 '24 12:07 aarmoa

Yes, you're right. let's close this PR

ThomasRalee avatar Jul 18 '24 13:07 ThomasRalee