injective-ts icon indicating copy to clipboard operation
injective-ts copied to clipboard

feat: support FoxWallet

Open ljunb opened this issue 1 year ago • 1 comments

Hi, We are FoxWallet team, and we want to add supporting FoxWallet in wallet-ts and wallet-evm. FoxWallet is multi-chain wallet that support Injective protocol. You can find more information about FoxWallet here.

Summary by CodeRabbit

  • New Features

    • Introduced two new wallet strategies: FoxWallet and FoxWalletCosmos.
    • Enhanced wallet interactions for Ethereum and Cosmos transactions with dedicated methods for account management and transaction handling.
    • Added support for detecting the Fox Wallet provider with initialization handling.
  • Bug Fixes

    • Improved error handling for wallet operations and transaction broadcasting.
  • Documentation

    • Updated interfaces to accommodate new wallet types and properties for better integration and detection.
  • Refactor

    • Enhanced existing functions to include support for the new wallet types without altering existing functionalities.

ljunb avatar Nov 18 '24 03:11 ljunb

Walkthrough

The changes introduce two new wallet strategies, FoxWallet and FoxWalletCosmos, into the wallet management system. This includes updates to the createStrategy function to accommodate these new types, along with the implementation of classes and methods for interacting with the Fox Wallet for both Ethereum and Cosmos transactions. New utility functions and modifications to existing interfaces enhance wallet detection and integration capabilities. The overall structure and error handling of the existing code remain consistent, ensuring a seamless extension of functionality.

Changes

File Change Summary
packages/wallet-ts/src/strategies/wallet-strategy/WalletStrategy.ts Added cases for Wallet.FoxWallet and Wallet.FoxWalletCosmos in createStrategy. Updated import statements.
packages/wallet-ts/src/strategies/wallet-strategy/strategies/FoxWallet/index.ts Introduced FoxWallet class with methods for wallet interactions, including transaction handling and error management.
packages/wallet-ts/src/strategies/wallet-strategy/strategies/FoxWallet/utils.ts Added utility functions for interacting with the Fox Wallet provider, including initialization and provider retrieval.
packages/wallet-ts/src/strategies/wallet-strategy/strategies/FoxWalletCosmos/foxwallet/index.ts Introduced FoxWallet class for Cosmos transactions with various wallet operations and error handling.
packages/wallet-ts/src/strategies/wallet-strategy/strategies/FoxWalletCosmos/index.ts Added FoxWalletCosmos class extending wallet functionality for Cosmos, with methods for device type, enabling, and transaction handling.
packages/wallet-ts/src/strategies/wallet-strategy/types.ts Updated interfaces to include new properties for Fox Wallet integration.
packages/wallet-ts/src/strategies/wallet-strategy/utils.ts Added Wallet.FoxWallet to isEthWallet function for wallet recognition.
packages/wallet-ts/src/types/enums.ts Updated Wallet enum to include FoxWallet and FoxWalletCosmos.
packages/wallets/wallet-base/src/types/enums.ts Updated Wallet enum to include FoxWallet and FoxWalletCosmos.
packages/wallets/wallet-base/src/types/provider.ts Updated interfaces to include new properties for Fox Wallet detection.
packages/wallets/wallet-base/src/utils/wallet.ts Added Wallet.FoxWallet to the isEthWallet function.
packages/wallets/wallet-evm/src/strategy/strategy.ts Added Wallet.FoxWallet to evmWallets and updated getEthereum method to support it.
packages/wallets/wallet-evm/src/strategy/utils/foxwallet.ts Introduced functions for interacting with the Fox Wallet provider in an Ethereum environment.
packages/wallets/wallet-evm/src/strategy/utils/index.ts Exported getFoxWalletProvider from foxwallet.js.
packages/wallets/wallet-strategy/src/strategy/WalletStrategy.ts Added case for Wallet.FoxWallet in createStrategy function.

Poem

🐰 In the land of wallets, new friends arise,
FoxWallet and Cosmos, a sweet surprise!
With strategies crafted, our paths intertwine,
Transactions and tokens, all in good time.
Hopping through code, with joy we embrace,
A world of new wallets, a magical space! ✨

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/wallet-ts/src/strategies/wallet-strategy/WalletStrategy.ts

Oops! Something went wrong! :(

ESLint: 7.32.0

Error: Error while loading rule 'jest/unbound-method': You have used a rule which requires parserServices to be generated. You must therefore provide a value for the "parserOptions.project" property for @typescript-eslint/parser. Occurred while linting /packages/wallet-ts/src/strategies/wallet-strategy/WalletStrategy.ts at throwError (/node_modules/@typescript-eslint/utils/dist/eslint-utils/getParserServices.js:39:11) at getParserServices (/node_modules/@typescript-eslint/utils/dist/eslint-utils/getParserServices.js:31:9) at create (/node_modules/@typescript-eslint/eslint-plugin/dist/rules/unbound-method.js:116:55) at Object.create (/node_modules/@typescript-eslint/utils/dist/eslint-utils/RuleCreator.js:38:20) at create (/node_modules/eslint-plugin-jest/lib/rules/unbound-method.js:47:88) at Object.create (/node_modules/eslint-plugin-jest/node_modules/@typescript-eslint/utils/dist/eslint-utils/RuleCreator.js:41:20) at createRuleListeners (/node_modules/eslint/lib/linter/linter.js:765:21) at /node_modules/eslint/lib/linter/linter.js:937:31 at Array.forEach () at runRules (/node_modules/eslint/lib/linter/linter.js:882:34)


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Nov 18 '24 03:11 coderabbitai[bot]