IngaFeick

Results 25 comments of IngaFeick

@MangeshBhamre you're using protobuf 2, not 3. If you want to switch to proto3, which I recommend for performance reasons, then please use the [official protobuf compiler](https://developers.google.com/protocol-buffers/docs/downloads) to generate proto3...

@MangeshBhamre > does that mean pdns also need to send me protobuf in ver3 format? Not necessarily. You can read protobuf2 data with a protobuf3 definition. It's not an elegant...

@MangeshBhamre interesting observation. That's a helpful hint actually. I will look into it asap, thanks!

@MangeshBhamre it should be safe to use 1.0.0, yes. The versions afterwards were related to speed improvement and code quality, afair, and not bugfixes.

Hi @MangeshBhamre! Sorry for the late reply. We have upgraded codec to 1.1.0 with a fresher version of the google protobug lib under the hood. Maybe that tackles your problems?...

@MangeshBhamre are you sure you are using a protobuf 3 file? The compiler typically generates _pb.rb files for version 3, and yours ends in .pb.rb. Unless you renamed the file...

Hi @MangeshBhamre, I don't recommend sticking with pb2 because the new lib is really much faster. Let's approach this differently: I can convert your protobuf definition into a version 3...

@MangeshBhamre can you please provide the new _pb.rb file that you generated?

@MangeshBhamre * about the "Protocol message contained an invalid tag" problem: I have added an integration test for your protobuf class and I cannot reconstruct the issue. Is it possible...