MOActionPlugin icon indicating copy to clipboard operation
MOActionPlugin copied to clipboard

Mouse Location stack does not check for cooldown / gcd / resources

Open Electrized opened this issue 4 years ago • 4 comments

As of current, unlike the similar feature from akira0245's smartcast (currently unavailable on api4), MOAction stacks with the property "Mouse Location" on an ability such as Feather Rain, Sacred Soil, or any other 3d world targeted ability does NOT account for cooldown / gcd or even missing resources and will play the animation of the ability regardless

I have 0 idea on how to fix this, but it might be of use looking at how akira0245's smartcast handles checks for being able to cast the spell

Also, this is NOT an issue on any of the other stack properties such as field / ui mouseovers from my experience, only Mouse Location

Heres a clip to demonstrate what happens when casting sacred soil with 0 resources / during GCD: https://streamable.com/38dn73

Electrized avatar Oct 09 '21 14:10 Electrized

Seemingly skips the clientside check for "is this ability ready" and sends the "place action" packet directly to the server, where the server denies it

Electrized avatar Oct 09 '21 14:10 Electrized

Mo didn't even check whether the place should be able to place a ground target skill and just send it… I am not sure whether this may lead to a ban. The source code is never updated so even a fix PR is impossible even I have worked with Akira and fixed some part of it.

wozaiha avatar Oct 11 '21 01:10 wozaiha

There also appears to be a problem with 'special' platforms, such as e4s. Asylum just attempts to, (and if range will cast) fly to the edge of the map instead of where it's targetted.

Now that Akira's is updated to API4 it's not too much of a problem using his implementation instead, but notably his doesn't put the ability in queue though, and doesn't go through UI elements like this implementation.

bladehawkz avatar Oct 12 '21 05:10 bladehawkz

MO update has fixed the cooldown issue.

bladehawkz avatar Oct 18 '21 10:10 bladehawkz