infisical icon indicating copy to clipboard operation
infisical copied to clipboard

feat(project-permissions): allow users to sort permissions on the UI

Open carlosmonastyrski opened this issue 8 months ago β€’ 2 comments

Description πŸ“£

https://github.com/user-attachments/assets/412eb592-ffaa-4299-b26d-02977be6a4b6

Type ✨

  • [ ] Bug fix
  • [ ] New feature
  • [ ] Improvement
  • [ ] Breaking change
  • [ ] Documentation

Tests πŸ› οΈ

# Here's some code block to paste some code snippets

Summary by CodeRabbit

  • New Features

    • Added drag-and-drop functionality for reordering permission policy items, including visual feedback during dragging.
    • Introduced a draggable handle with a tooltip for easier item movement.
  • Style

    • Enhanced visual cues to indicate when items are being dragged or hovered over.

carlosmonastyrski avatar Apr 25 '25 22:04 carlosmonastyrski

Walkthrough

The GeneralPermissionPolicies component was modified to support drag-and-drop reordering of permission policy items. The useFieldArray hook was updated to destructure fields, remove, insert, and move directly. Two new state variables track the index of the dragged item and the drag-over target. Event handlers were added to manage drag lifecycle events: starting a drag, dragging over an item, dropping to reorder, and ending the drag. Each permission policy item now includes a draggable handle icon shown when not disabled, and conditional styling highlights the drag-over target and dims the dragged item. The permission select and tooltip were moved inside a flex container for layout consistency. Insertions and removals use the destructured functions directly, and all references to items.fields were replaced with fields. The component’s external interface remains unchanged, with internal logic and UI updates enabling interactive reordering.


πŸ“œ Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 1e9722474fa0ed8ae89064777d7fe86c4bc74144 and 2e459c161d7e6107f6930e5f688493cb223f849d.

πŸ“’ Files selected for processing (1)
  • frontend/src/pages/project/RoleDetailsBySlugPage/components/GeneralPermissionPolicies.tsx (6 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/src/pages/project/RoleDetailsBySlugPage/components/GeneralPermissionPolicies.tsx
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Check Frontend Type and Lint check
✨ Finishing Touches
  • [ ] πŸ“ Generate Docstrings

πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 25 '25 22:04 coderabbitai[bot]

:tada: Snyk checks have passed. No issues have been found so far.

:white_check_mark: security/snyk check is complete. No issues have been found. (View Details)

maidul98 avatar Apr 25 '25 22:04 maidul98