infisical icon indicating copy to clipboard operation
infisical copied to clipboard

fix(secrets-table): UI fix for users with edit permissions but not read secret value permission

Open carlosmonastyrski opened this issue 8 months ago • 2 comments

Description 📣

Context: Before users were not able to edit the value of a secret unless it was using the side-panel when read value permissions were not set (but edit permissions were set).

Type ✨

  • [ ] Bug fix
  • [ ] New feature
  • [ ] Improvement
  • [ ] Breaking change
  • [ ] Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

Summary by CodeRabbit

  • New Features
    • Added interactive blurred placeholders for hidden secret values, allowing users with edit permission to reveal and edit secrets even if they lack read permission.
    • Enhanced tooltips to clarify edit permissions when secret values are hidden.
  • Improvements
    • Improved form reset and default value logic for secret fields based on user permissions and secret visibility.
    • Secret input now auto-selects content on focus for easier editing.
    • Personal secrets marked as hidden now reveal their actual values, while others remain masked.

carlosmonastyrski avatar Apr 24 '25 00:04 carlosmonastyrski

"""

Walkthrough

The changes introduce new permission-based logic and interactive UI behavior for handling secret values in the secret manager frontend. Across the affected components, a new boolean state is added to track whether the secret blur placeholder is focused. Permission checks are implemented to determine if a user can edit a secret value, influencing both the display and interaction with secret values. The default value logic for secret inputs is centralized through helper functions that consider both the visibility of the secret and the user's permissions. When a secret value is hidden, users with edit permission are shown a clickable masked placeholder; clicking this allows them to toggle and interact with the input field. Tooltip messages are updated to reflect edit permissions even when read access is restricted. Form reset logic is adjusted to handle the new interaction patterns, ensuring the UI state remains consistent with user actions and permissions. Additionally, the static blur component is replaced with a custom inline masked placeholder rendering. A minor enhancement is made to the SecretInput component to auto-select the textarea content on focus. All changes are internal to the respective React components and do not alter exported or public APIs.

Suggested reviewers

  • maidul98

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f9c936865ab783991609d52dd1bfe55b9c259129 and 35749e8d1225749f30d6a340c451f6307de169e8.

📒 Files selected for processing (1)
  • frontend/src/pages/secret-manager/OverviewPage/components/SecretOverviewTableRow/SecretEditRow.tsx (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/src/pages/secret-manager/OverviewPage/components/SecretOverviewTableRow/SecretEditRow.tsx
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Check TS and Lint
  • GitHub Check: Run integration test
  • GitHub Check: Check Frontend Type and Lint check
✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 24 '25 00:04 coderabbitai[bot]

:tada: Snyk checks have passed. No issues have been found so far.

:white_check_mark: security/snyk check is complete. No issues have been found. (View Details)

maidul98 avatar Apr 25 '25 11:04 maidul98