infisical icon indicating copy to clipboard operation
infisical copied to clipboard

Feat/azure client secrets rotation

Open carlosmonastyrski opened this issue 8 months ago • 2 comments

Description 📣

Type ✨

  • [ ] Bug fix
  • [ ] New feature
  • [ ] Improvement
  • [ ] Breaking change
  • [ ] Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

Summary by CodeRabbit

  • New Features

    • Added support for Azure Client Secrets as a new app connection type with OAuth authentication.
    • Introduced Azure Client Secret Rotation for automated secret management with customizable parameters and secret mappings.
    • Added UI components and forms for creating, updating, and reviewing Azure Client Secrets connections and rotations.
    • Enabled fetching and selection of Azure applications during secret rotation setup.
    • Extended API endpoints and documentation to fully support Azure Client Secrets connections and secret rotations.
  • Documentation

    • Added detailed user guides and API references for Azure Client Secrets connections and secret rotation configuration.
  • Chores

    • Updated enums, type definitions, internal mappings, and service integrations to incorporate Azure Client Secrets across the platform.

carlosmonastyrski avatar Apr 16 '25 22:04 carlosmonastyrski

"""

Walkthrough

This change introduces comprehensive support for Azure Client Secret rotation and Azure Client Secrets app connections throughout the codebase. On the backend, new enums, types, schemas, constants, and service logic are added to handle Azure client secret rotation, including issuing, revoking, and rotating Azure client secrets via Microsoft Graph API. New router registration functions and endpoint handlers are provided for both app connections and secret rotations related to Azure. The app connection logic is extended to support OAuth-based Azure connections, including credential validation, token refresh, and listing Azure applications. On the frontend, new React components and form schemas enable users to create, update, and review Azure client secret rotations and connections, including hooks to fetch Azure clients. The documentation is updated with new API reference pages and platform guides for Azure Client Secret integration and rotation. All relevant union types, enums, and mappings are extended to include the new Azure-related types and functionality.

Possibly related PRs

  • Infisical/infisical#3470: Adds support for AWS IAM User Secret rotation, introducing new secret rotation types, routers, schemas, factories, and type unions similar in structure and purpose to the Azure Client Secret rotation features added in this PR.

Suggested reviewers

  • maidul98 """

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d161be1170e7569184854a8956c5400ad86cf421 and 35b8adb0f60eaa40131d420cb02ab2e6a6db26f6.

📒 Files selected for processing (1)
  • docs/mint.json (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/mint.json
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: Mintlify Deployment
  • GitHub Check: Check API Changes
  • GitHub Check: Check Frontend Type and Lint check
  • GitHub Check: Check TS and Lint
  • GitHub Check: Run integration test

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 16 '25 22:04 coderabbitai[bot]

:tada: Snyk checks have passed. No issues have been found so far.

:white_check_mark: security/snyk check is complete. No issues have been found. (View Details)

maidul98 avatar Apr 25 '25 16:04 maidul98