infisical icon indicating copy to clipboard operation
infisical copied to clipboard
verified publisher icon Infisical

fix(ui): scroll layout issue on zoom

Open ShobhitPatra opened this issue 8 months ago • 1 comments

Description 📣

This PR fixes a layout issue where scrolling only worked when zoomed in. resolves issues https://github.com/Infisical/infisical/issues/1411 https://github.com/Infisical/infisical/issues/1576

Type ✨

  • [ x] Bug fix
  • [ ] New feature
  • [ ] Improvement
  • [ ] Breaking change
  • [ ] Documentation

Tests 🛠️

previous behaviour : https://www.loom.com/share/54494c7b4fc44491a94a16c9e4ffbe50?sid=d3c90686-59f3-4993-b6ce-71886bb8409e

aftex fix : https://www.loom.com/share/d9d0e2d58f76474fb6a7ce946b2a2c53?sid=b3bcedf1-d2c8-434d-87f6-10c7a49ed5fb

# Here's some code block to paste some code snippets

Summary by CodeRabbit

  • Style
    • Updated alignment of elements on the Login and Sign Up pages for improved horizontal centering.

ShobhitPatra avatar Apr 16 '25 06:04 ShobhitPatra

Walkthrough

The changes update the CSS class names on the main container divs in both the LoginPage and SignUpPage components. Specifically, the class justify-center is replaced with items-center in each component. This adjustment modifies the alignment of child elements within the flex containers, shifting from vertical centering (justify-center) to horizontal centering (items-center) along the cross axis. No other code, logic, rendering, or exported entities are modified in these files. The updates are limited to the container divs’ class attributes, affecting only layout alignment.

[!TIP]

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0f7e8585dc2afefb4049111f7abbd9743dea8624 and 67d68f20b37fe47d65a818d3e65facd9fda2ec9b.

📒 Files selected for processing (2)
  • frontend/src/pages/auth/LoginPage/LoginPage.tsx (1 hunks)
  • frontend/src/pages/auth/SignUpPage/SignUpPage.tsx (1 hunks)
🔇 Additional comments (2)
frontend/src/pages/auth/LoginPage/LoginPage.tsx (1)

64-64: Layout alignment fix is correct and safe.

Switching from justify-center to items-center on the flex container resolves the scroll layout issue at different zoom levels, as described in the PR objectives. No further action needed.

frontend/src/pages/auth/SignUpPage/SignUpPage.tsx (1)

129-129: Consistent layout alignment fix.

Changing from justify-center to items-center ensures proper horizontal centering and resolves the scroll layout issue, matching the fix in the LoginPage. No further action needed.

✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 16 '25 06:04 coderabbitai[bot]