infisical icon indicating copy to clipboard operation
infisical copied to clipboard

prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers

Open jsoref opened this issue 1 year ago • 0 comments

This message comes from kubernetes, a user encountered it:

https://questions.infisical.com/2J3ea21

2024-08-27T01:25:28Z INFO KubeAPIWarningLogger metadata.finalizers: "http://secrets.finalizers.infisical.com|secrets.finalizers.infisical.com": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers

The code in Infisical is: https://github.com/Infisical/infisical/blob/d430293c66c095fc590b6cae233d280c0992edd6/k8-operator/controllers/infisicalsecret_controller.go#L52

In theory the fix is something like this:

- const FINALIZER_NAME = "secrets.finalizers.infisical.com" 
+ const FINALIZER_NAME = "secrets.infisical.com/finalizer"

In practice, you may need to include some migration support, here's how I did it for cert-manager: https://github.com/cert-manager/cert-manager/commit/bbb21d5d9a41c51c6df5199ba541dfcf3624660c

jsoref avatar Sep 27 '24 18:09 jsoref