infisical icon indicating copy to clipboard operation
infisical copied to clipboard

feat(identities/machine): add ability to disable a machine identity

Open GLEF1X opened this issue 1 year ago • 3 comments

Description 📣

This pull request introduces a new feature that allows the enabling or disabling of machine identities without the need to delete them or their related client secrets. This is particularly useful in scenarios where temporarily pausing the usage of an identity is necessary. The addition of this feature enhances the flexibility and control over machine identities within the system.

Changes

  • Database Update: Added a new isDisabled boolean column to the identities table to track the enabled/disabled state of each identity.
  • Added the ability to toggle the isDisabled state on the identity detail page, allowing users to enable or disable an identity as needed.
  • Added Disabled column to the identity data table.

Type ✨

  • [ ] Bug fix
  • [x] New feature
  • [ ] Breaking change
  • [ ] Documentation

Tests 🛠️

https://github.com/user-attachments/assets/40aa45b5-b06c-407b-89ed-dfb95cac7261

# Here's some code block to paste some code snippets

Resolves #2240

GLEF1X avatar Aug 09 '24 01:08 GLEF1X

Hey @GLEF1X!

Can you please adjust the UI side here to be inline with the UI/UX for suspending users on the platform? Except instead of suspended it would be disabled.

Here's a screenshot of what that would look like:

Screenshot 2024-08-09 at 7 38 18 AM

dangtony98 avatar Aug 09 '24 15:08 dangtony98

@GLEF1X @dangtony98 i was thinking may be disable need not be in the edit modal rather just beside the identity details banner as the checkbox. Because disable in edit feels a bit unintuitive and users may not find it

akhilmhdh avatar Aug 11 '24 14:08 akhilmhdh

@akhilmhdh Thanks for the suggestion! I considered moving the disable option out of the edit modal and placing it beside the identity details banner as a checkbox. However, I felt that following the AWS design approach might be more user-friendly, so I ended up adding disable/enable identity as a dropdown item. @dangtony98 I've also made the requested adjustments to the UI/UX of the table.

AWS examples:

CleanShot 2024-08-18 at 01 38 25@2x CleanShot 2024-08-18 at 01 38 52@2x CleanShot 2024-08-18 at 01 49 28@2x

End result

https://github.com/user-attachments/assets/f9c41ca1-c4d0-4361-8bd8-98da9245e729

GLEF1X avatar Aug 18 '24 05:08 GLEF1X

is this resolved?

Devilla avatar Jul 07 '25 08:07 Devilla