infisical
infisical copied to clipboard
refactor(aws-ps-integration): make `AWS Parameter Store` integration easier to use
Description 📣
This pull request refactors the AWS Parameter Store
integration UI to enhance the user experience and improve code maintainability. The changes introduce a new IntegrationAuth component and update the form handling process.
Issues Fixed
- Improves form validation and error handling for AWS Parameter Store integration setup.
- Resolves an issue where incomplete form validation allowed submission of incomplete data, resulting in database constraint violations(see video for more details).
- Allows user to deselect AWS KMS key after selecting one.
Other Improvements
- The
autoFocus
attribute is now applied to the initial input fields in the form's DOM structure. Specifically, theenvironment
andaccessId
fields are set to automatically receive focus when the form loads. - Enhances code reusability with the new
IntegrationAuth
andIntegrationCreate
components. This will allow to create or refactor integrations faster.
Type ✨
- [x] Bug fix
- [x] Refactoring
- [ ] New feature
- [ ] Breaking change
- [ ] Documentation
Tests 🛠️
- Verified that all form validations work as expected.
- Tested the integration process with various AWS regions and KMS key scenarios.
- Ensured compatibility with existing integration data and processes.
- [x] I have read the contributing guide, agreed and acknowledged the code of conduct. 📝
Videos
How it used to work
https://github.com/user-attachments/assets/875002d4-12e0-4854-8264-e9070cb7f0c0
After this PR is merged:
https://github.com/user-attachments/assets/fc8c3047-0bc6-44cf-a453-a92c5d96b304