infisical icon indicating copy to clipboard operation
infisical copied to clipboard

feat: cli env upload

Open quinton11 opened this issue 1 year ago • 3 comments

Closes #1612 @maidul98

@akhilmhdh wrt the commented out block in secret-service.ts, using the cli secrets set command, where in this case the secret key already exists, instead of updating the existing secret with the new value it always gave this response

error: CallUpdateSecretsV3: Unsuccessful response. Please make sure your secret path, workspace and environment name are all correct [response={"statusCode":400,"message":"Secret already exist","error":"BadRequest"}]
Unable to process secret update request

Commenting out that block resolves it. Is it by design or its a bug?

quinton11 avatar May 12 '24 20:05 quinton11

Hey @quinton11 Its a valid block and it should not be commented out. Its a check to ensure the new key submitted doesn't exist

akhilmhdh avatar May 15 '24 05:05 akhilmhdh

@akhilmhdh pushed an update undoing the comment

quinton11 avatar May 16 '24 21:05 quinton11

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9605380 Triggered Generic Private Key 5c495cf313db07430387a3bf56b8d477801c3f02 backend/e2e-test/routes/v3/secrets-v2.spec.ts View secret
9605380 Triggered Generic Private Key 5c495cf313db07430387a3bf56b8d477801c3f02 backend/e2e-test/routes/v3/secrets-v2.spec.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Aug 22 '24 14:08 gitguardian[bot]