infisical icon indicating copy to clipboard operation
infisical copied to clipboard

Add smon/promrules to infisical secrets-operator

Open Allex1 opened this issue 2 years ago • 3 comments

Description 📣

Add prometheus-operator objects for monitoring the operator.

@maidul98 somehow I managed to close https://github.com/Infisical/infisical/pull/1083 by mistake. Added feature flags and defaulted to false in order to keep it backward compatible as some users might not have the crds deployed at the time of deploying this chart.

Type ✨

  • [ ] Bug fix
  • [x] New feature
  • [ ] Breaking change
  • [ ] Documentation

Tests 🛠️

Tested on a local k8s cluster where I run the operator and a kps stack and started scraping the manager and added alerts

❯ helm lint ./secrets-operator
==> Linting ./secrets-operator
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed

helm template infisical ./secrets-operator

Allex1 avatar Dec 20 '23 08:12 Allex1

The changes you have made will get overwritten when we run the command to generate the helm chart. Can you please ensure that these changes do not get overwritten when we run this command https://github.com/Infisical/infisical/blob/main/k8-operator/Makefile#L41

maidul98 avatar Feb 16 '24 16:02 maidul98

@maidul98 Updated the kustomize manifests to generate correct helm manifests but after running make helm-chart some older stuff that was committed without generating came in the helm chart. Updated the helm chart version. imho getting helm charts from kustomize is not ideal as the manifests lack flexibility but it's better than nothing I guess.

Allex1 avatar Feb 17 '24 14:02 Allex1

also interested in this one, @maidul98 are the updates from @Allex1 ok?

vtmocanu avatar Aug 05 '24 08:08 vtmocanu