PipePipe icon indicating copy to clipboard operation
PipePipe copied to clipboard

[Bug] Channel Filter does not affect all channels

Open flusteredcustard opened this issue 8 months ago • 1 comments

Checklist (Your issue will be automatically closed if you delete this part)

  • [ X] I make sure that there are no existing issues - open or closed - which I could contribute my information to.
  • [X ] I understand that issues with limited impact, such as those occurring on specific devices or under specific network conditions, will not be fixed.
  • [X ] I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • [ X] I have attached the error report in the issue.

Describe the bug Certain channels are not caught by the channel filter, appearing in my recommended videos and searches despite being filtered. Frequency I'm not sure what causes the channels to be affected by this bug, or how many are affected, but I know at least one channel that consistently slips through Steps to reproduce the bug Navigate to the channel Asmongold TV, long press on any video, and add it to the channel blocklist. Then perform a search for the channel. Even with blocked channels omitted from search results, it will appear. Compare with a different channel, such as MrBeast, which functions as expected with the previous steps and has the videos omitted from the search results. Device (e.g. Pixel 9 Pro) OnePlus Nord N200 Error report No error report is generated, only unintended behavior. Additional context I've double checked that my settings are correct and blocking searches by doing searches for channels that I've blocked, and seeing no videos from them.

flusteredcustard avatar Apr 10 '25 14:04 flusteredcustard

From what I can tell, this is being caused by a recent update that automatically adds a space after each comma in the filter list to make it more easily readable, and then ignores those spaces while checking the name of a channel to see whether it should be filtered. Apparently, something about the way this was implemented ignores spaces in front of commas as well; if you look at it in the filter list or highlight it in a browser, you can see that the name of the channel mentioned here is actually "Asmongold TV ", with two spaces at the end (for no reason that I can discern). There's one other channel I've seen with this quirk, "Police Watch ". As long as you added those stray spaces, both of these channels were properly filtered in versions from before this change was made. The simple solution for this specific issue is to make it so that spaces are ignored only at the beginning of each list item and not the end, but I also propose that, if possible, the developer adds support to filter by @ handles (@AsmonTV) and channel IDs (UCQeRaTukNYft1_6AZPACnog). My reasoning for this is that there are some channels with commas in their names ("Ryan Hall, Y'all" and "Oops, all Sunny!" to name some) that, as far as I can tell, are physically unable to be filtered using the current comma-separated system.

Koly39 avatar Apr 11 '25 16:04 Koly39

Thanks. Fixed in 4.3.0

InfinityLoop1308 avatar Apr 22 '25 23:04 InfinityLoop1308