PipePipe icon indicating copy to clipboard operation
PipePipe copied to clipboard

[Bug] "Ask where to download" and bilibili video download error

Open facaikotei opened this issue 1 year ago • 4 comments

Checklist (Your issue will be automatically closed if you delete this part)

  • [ ] I make sure that there are no existing issues - open or closed - which I could contribute my information to.
  • [x] I understand that issues with limited impact, such as those occurring on specific devices or under specific network conditions, will not be fixed.
  • [x] I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • [x] I have attached the error report in the issue.

Describe the bug A "post-processing failed" occurs when download bilibili video if "Ask where to download" is enabled. Frequency Always Steps to reproduce the bug Enable "Ask where to download". Download a bilibili video. Download failed. Device (e.g. Pixel 9 Pro) Samsung galaxy s22 Error report

Exception

  • User Action: download post-processing
  • Request: https://bilibili.com/BV1VJkZYeEm3?p=1 [ {type=video format=MPEG-4 quality=720P 高清 videoOnly=true} {type=audio format=m4a bitrate=-1} ]
  • Content Country: TW
  • Content Language: zh-TW
  • App Language: zh_TW_#Hant
  • Service: BiliBili
  • Version: 4.0.2
  • OS: Linux Android 14 - 34
Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'java.io.File[] java.io.File.listFiles()' on a null object reference
	at us.shandian.giga.util.Utility.removeTempFileOfDownloadedVideo(Utility.java:347)
	at us.shandian.giga.postprocessing.Postprocessing.run(Postprocessing.java:213)
	at us.shandian.giga.get.DownloadMission.doPostprocessing(DownloadMission.java:706)
	at us.shandian.giga.get.DownloadMission.$r8$lambda$J0GR1urTFneOp2O30GpOM3TNG0I(Unknown Source:0)
	at us.shandian.giga.get.DownloadMission$$ExternalSyntheticLambda0.run(Unknown Source:2)
	at java.lang.Thread.run(Thread.java:1012)


Additional context #295 3.5.0 and #225 3.3.1 have same bug fixed and closed. But in latest 4.0.2 version, it only "fixed" if "Ask where to download" is disable.

facaikotei avatar Dec 29 '24 08:12 facaikotei

Fixed in the latest build.

InfinityLoop1308 avatar Jan 08 '25 08:01 InfinityLoop1308

Fixed in the latest build.

4.1.0, not fixed Screenshot_20250110_175219_PipePipe Screenshot_20250110_174830_PipePipe Screenshot_20250110_174721_PipePipe

facaikotei avatar Jan 10 '25 10:01 facaikotei

Exception

  • User Action: download post-processing
  • Request: https://bilibili.com/BV1tsrPYqEb6?p=1 [ {type=video format=MPEG-4 quality=720P 高清 videoOnly=true} {type=audio format=m4a bitrate=-1} ]
  • Content Country:
  • Content Language: en-
  • App Language: en
  • Service: BiliBili
  • Version: 4.1.0
  • OS: Linux Android 14 - 34
Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'androidx.documentfile.provider.DocumentFile[] androidx.documentfile.provider.DocumentFile.listFiles()' on a null object reference
	at us.shandian.giga.util.Utility.removeTempFileOfDownloadedVideo(Utility.java:360)
	at us.shandian.giga.postprocessing.Postprocessing.run(Postprocessing.java:213)
	at us.shandian.giga.get.DownloadMission.doPostprocessing(DownloadMission.java:706)
	at us.shandian.giga.get.DownloadMission.$r8$lambda$J0GR1urTFneOp2O30GpOM3TNG0I(Unknown Source:0)
	at us.shandian.giga.get.DownloadMission$$ExternalSyntheticLambda0.run(Unknown Source:2)
	at java.lang.Thread.run(Thread.java:1012)


facaikotei avatar Jan 10 '25 10:01 facaikotei

@InfinityLoop1308

facaikotei avatar Jan 10 '25 13:01 facaikotei

Fixed in 4.4.0

InfinityLoop1308 avatar May 20 '25 01:05 InfinityLoop1308