PipePipe icon indicating copy to clipboard operation
PipePipe copied to clipboard

[Bug]Collision between two gesture commands

Open Pafzedog opened this issue 1 year ago • 7 comments

Checklist (Your issue will be automatically closed if you delete this part)

  • [x] No "Found a solution for the error you encountered" notification was shown when opening the error report.
  • [x] I make sure that there are no existing issues - open or closed - which I could contribute my information to.
  • [x] I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • [ ] I have attached the error report in the issue.

Describe the bug Hello, since version 3.8, there is a collision between two gesture actions.

  • swipe down to lower sound
  • swipe down to minimize video.

Steps to reproduce the bug When full screen, swipe down On the right half of the screen to lower sound level, sometime sound level is lowered, sometime video starts to be minimized. Device (e.g. Pixel 9 Pro) Oneplus nord 2t Error report No error report Additional context

Pafzedog avatar Sep 24 '24 08:09 Pafzedog

When in full screen mode, the screen is now divided into three vertical sections:

  • Left section (approximately 1/3 of the screen width)
  • Middle section (approximately 1/3 of the screen width)
  • Right section (approximately 1/3 of the screen width)

You need to swipe down on the middle section to minimize.

InfinityLoop1308 avatar Sep 25 '24 22:09 InfinityLoop1308

Thank you but I think I didn't explain myself correctly, it's not getting out of full screen but all the video is getting "dockerized" in the bottom of the screen . check the screen record attached please.

https://github.com/user-attachments/assets/87a8d3f7-6e89-4101-bb81-044b668fdf17

Pafzedog avatar Sep 26 '24 06:09 Pafzedog

Yeah that is expected. If the controls are visible (the overlay which contains the play/pause button, title, author, menu, etc.), swiping down will minimize the video; otherwise it will decrease the volume. You can click to switch the visibility of the overlay.

InfinityLoop1308 avatar Sep 26 '24 06:09 InfinityLoop1308

Ok, I understand. But you can see that the second time, the video is minimized whereas there is no overlay and it's often happening. I didn't face this never before latest versions.

Pafzedog avatar Sep 26 '24 07:09 Pafzedog

I tried many times and it seems quite random to me... It occurs like 1 in 20 and I can't find a way to reproduce it.

InfinityLoop1308 avatar Sep 27 '24 09:09 InfinityLoop1308

It would be helpful if you can provide a stable method to trigger the issue.

InfinityLoop1308 avatar Sep 27 '24 09:09 InfinityLoop1308

I too am facing the issue that @Pafzedog shared in their screen recording, and yes, as you (boss man) stated, it is random, but it's this very randomness that makes it annoying. I am aware that there are users that wanted this new gesture system (assumption), but imo it detracts from the simple yet useful old method of volume/brightness right/left two vertical interfaces that just worked every time until there is a better implementation of these 3 vertical partitions without it randomly minimizing etc. Providing an option in setting to revert back to the old 2-way partition would be much appreciated. Thanks for your time and effort in addressing this issue.

cincinnatus0 avatar Sep 28 '24 08:09 cincinnatus0

It would be helpful if you can provide a stable method to trigger the issue.

Sorry but I can't figure out what is triggering this or that action.

It occurs like 1 in 20

To me, it's near to half the time

Pafzedog avatar Oct 03 '24 11:10 Pafzedog

In the next version, there will be a switch to control whether to enable this feature or not. image Test apk: https://github.com/InfinityLoop1308/PipePipe/actions/runs/11642406985

InfinityLoop1308 avatar Nov 02 '24 11:11 InfinityLoop1308

Thank you !

Pafzedog avatar Nov 02 '24 14:11 Pafzedog