Yarn icon indicating copy to clipboard operation
Yarn copied to clipboard

Resizing window to narrow profile offsets connection lines

Open b-erv opened this issue 6 years ago • 7 comments

When the Yarn window is close to or at its minimum width, any lines between nodes get shunted to one side and no longer line up. Happening for me consistently at various resolutions and display magnification settings. resize

b-erv avatar Aug 09 '18 18:08 b-erv

Does that also happen in the electron version?

Also can you please zip the file you have open and attach it to your post here

On Thu, Aug 9, 2018 at 7:36 PM b-erv [email protected] wrote:

When the Yarn window is close to or at its minimum width, any lines between nodes get shunted to one side and no longer line up. Happening for me consistently at various resolutions and display magnification settings. [image: resize] https://user-images.githubusercontent.com/17258819/43918439-15efe6d4-9be1-11e8-9d2a-435489c3c8b5.gif

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/InfiniteAmmoInc/Yarn/issues/77, or mute the thread https://github.com/notifications/unsubscribe-auth/AGMbVdfrDeam8R68HCTqW0vHLJVPDXPnks5uPIEwgaJpZM4V2M8W .

blurymind avatar Aug 09 '18 20:08 blurymind

Yes, the same behaviour is occurring for me across versions. Additionally, it happens the same way with all .yarn files, even newly-created ones. Such as here: demo.yarn.txt

b-erv avatar Aug 10 '18 21:08 b-erv

I've been able to reproduce the issue with the NWjs build (aka master) but not with the electron build.

Maybe it has to do with this? Not sure.

/* --- MEDIA --- */

@media (max-width: 830px) {
	.app-search {
		position: relative;
		float: left;
	}
	.app-menu {
		position: relative;
		float: right;
		margin-top: 20px;
	}
}

julsam avatar Aug 11 '18 06:08 julsam

for the electron build - if it aint broke - no need to fix it :) might cause some regression

blurymind avatar Aug 11 '18 09:08 blurymind

@blurymind you misunderstood me :wink: I was pointing out that the issue could be related to this css rule in the master branch, not the electron one :stuck_out_tongue:

This css rule will move the right menu buttons when the window's width is lower than 830px, which is when the issue with the arrows seems to be happening. But I've only been working in the electron branch so far, so I'm not sure what's really happening, I'll let others investigate.

julsam avatar Aug 11 '18 09:08 julsam

@julsam do we patch it in the nwjs version? I want to focus on maintaining the electron one

blurymind avatar Aug 13 '18 07:08 blurymind

@blurymind it's not a major bug, so i'm not sure patching the nwjs is worth it since the plan is to go full electron in the long term. There's a lot more important issues to fix in the nwjs version anyway (but i'm more focused on the electron branch myself).

julsam avatar Aug 25 '18 12:08 julsam