nix-minecraft icon indicating copy to clipboard operation
nix-minecraft copied to clipboard

Transfer documentation from module to README

Open Silverdev2482 opened this issue 1 year ago • 4 comments

I think this is mostly good but I'm not sure about the syntax of how I named options, I also wouldn't be suprised as if there are a few spelling errors. It still need proofreading by me too.

Silverdev2482 avatar Jan 29 '24 14:01 Silverdev2482

Will servers.<name.files> Only place non existing files, or will it overwrite them? I would like to specify that in the README. Did a quick skim over and it looked fine but I missed some xml/html? tags that I don't think are necessary. also I should change that link to the new Minecraft wiki instead of the old one but it looks good to me.

Silverdev2482 avatar Jan 29 '24 14:01 Silverdev2482

Looking at it I believe it will put the files into a .bak when modified, but will overwrite the previous.bak file, if I am wrong please correct me.

Silverdev2482 avatar Jan 29 '24 17:01 Silverdev2482

All suggestions look good to me, I wasn't too sure on format/syntax so I went to what seems the most similar with the existing readme. Not sure if I feel like documenting the files option, as I don't have the best understanding of the nix language. If @Misterio77 feels like documenting that we should wait, or maybe a make separate issue and pr. Other than that this seems all good to merge.

Silverdev2482 avatar Feb 12 '24 01:02 Silverdev2482

Should that issue be created and this merged? Or do we add that to this PR and wait for it to be documented?

Silverdev2482 avatar Feb 13 '24 13:02 Silverdev2482

Don't mean any disrespect, but should we just merge this now? If I am not mistaken there isn't anything I need to do, and Misterio hasn't responded. Every other suggestion looks fine and has been approved.

Silverdev2482 avatar Jul 11 '24 22:07 Silverdev2482

Sorry for the wait, summer has been pretty busy for me so even though this is small and straight forward, it kept getting pushed back by the other things I've been doing.

Infinidoge avatar Jul 11 '24 22:07 Infinidoge