InfiniTime
InfiniTime copied to clipboard
InfiniTimeOrg
Feature to disable touchscreen
Adds a rain mode toggle to the quick settings, which disables the touch
panel.
Currently the symbols for rain mode and flashlight don't show up, and
the touch panel only updates after it is touched once.
The flashlight app has been moved to the apps menu, and rain mode can
be disabled via "longer pressing" the button, like accessing the info
app.
I've noticed that if I'm walking in the rain, and I check my watch, the raindrops make a bunch of touch events that take me off the clock screen. By disabling the touch panel I can check the time in the rain.
I was once in the mountains and soaked completely after few hours. The watch was completely useless. This feature would be awesome if it would work nice
+1. Usage: Under shower to control music without water drops messing in all menu. At pool to see time (can't wear corrective glasses/lens)
I think that this is different from 894, because that one just disables waking the watch entirely, which means you can't use it to tell the time anymore. This PR just disables the touch panel, so you can still check the time.
We don't want to encourage people putting their PineTimes in water, as they're not actually all that waterproof. It's unlikely for these PRs to be merged.
The way I understood it, PineTimes are waterproof enough for rain, but not really for submerging or showering, because of the heat and soap. I'd be happy to accept if it's not even waterproof enough for rain, and then I'll just close this.
Maybe it's fine for a bit of rain, but if we provide a feature like this, people would misuse it anyway ☝
@Riksu9000 this feature is maybe be not that good for rain/shower but is when putting the pinetime in the jeans' pocket !
i explain : when it's rain a lot ,or when i need to , i put the pinetime inside the jean's pocket (, putting it here allow me to have the steps tracked properly ), but in the jeans pocket there is also other things, like money / key / cards ..., that activate the screen unknown to me ,and drain the pinetime ! Even more when i retrieve the pinetime from the pocket and use it , most time than not, it's already showing the screen ! if the shake to wake is activated then it will remain activated by every thing here at every movement and every touch... (sometime , it even activated the music app , on bus...) or worst the flash was activated and drain way faster the pinetime
that's why i truly need this pr because regardless of rain or not , it will allow me easily to put the pinetime in the pocket and it will not be drained whether by the shake to wake i activated or the touch screen , because the touch screen will remain disabled until i push the button and activated the screen again!
i thinks the toogle for this on quick setting , is a good choice , because it will allow to activate it faster !
what do you thinks of this purpose and this pr @JF002 ?
Some points I'll you known too.
Dry feature
It's winter here, so long coats and sweaters, somehow the cloth activate menu and often my watch play pong by itself.
Water
First time I used watch underwater to test the "PineTime comes with a IP67 rating, meaning that it can handle up to one meter of water and is fully dust proof", the menu come crazy and to watch time I need to push a lot the button (that break the seal and allow water to come in), and the watch break, put it in rice and dry it, work fine since.
Was a bad move but the website is unclear, maybe we could work on it instead of restrict users feature.
My point is to keep the seal and waterproof you need to keep the button unpushed underwater, so avoiding user to use it could help keeping it sealed, even on misuse.
Now I still use it underwater, and the feature will help but without that don't prevent not use it.
In shower I don't keep it on wrist, keep as dry as possible but still some droplets on it, like rain.
I wasn't clear on my last comment, but allowing disable touch feature could help for other usage than just try to prevent user to misuse they watch.
Thanks for reading have a great day.
Or maybe say just show a warning that pinetime is not really made for use in heavy rain, and this mode is meant to block unintended touches.
It's useful regardless of rain IMO, there's been many times where I'm doing heavy activity, I go to check the time, and it's either on a different screen or it's changed a setting somehow (I've accidentally turned off vibration before, causing me to miss notifications).
If you view it as a lock/hold mode, it makes a lot of sense. Similar to how old MP3 players had a hold switch for when it was rumbling around in your pocket. It'd be useful too for the times that I have to throw my pinetime in a bag.
Would love to see this feature added, although I 100% don't want the flashlight moved, I use it super often and having it in the quick settings is very useful.
The issue here is that this is a rain mode, not a locking mode. They may work very similarily, but the other references water, which is not good. People are suggesting use cases that don't have to do with rain, but in the end this feature is still presented as a rain mode. Check #395 and #697 for locking related issues. Some issues mentioned here probably relate to raise wrist being too sensitive #548.
The issue here is that this is a rain mode, not a locking mode. They may work very similarily, but the other references water, which is not good. People are suggesting use cases that don't have to do with rain, but in the end this feature is still presented as a rain mode. Check #395 and #697 for locking related issues. Some issues mentioned here probably relate to raise wrist being too sensitive #548.
if i understand right @Riksu9000 , as long as the title is changed from "[Rain mode feature]" to for example "[lock screen mode feature] , you are willing to approve the feature ? if it's only a title , maybe @FintasticMan could change it (the pr title and if needed the title setting as well).
for the rain or water part , that's the "lock mode" could help with , if you have resentment about , you should send it to the pine64 team not on this pr , it's fruitless and misplaced to do it here : because , as long as it's written on the product page of the pinetime that it can withstand rain or shower , then people will use on these case whether you like it or not ,because it's written that they could do it!
(example some casio's watch page product have written inside that they can withstand high level of water pressure , so people will buy it and use it on theses case because it written they can !)
Trying to "disapprove" pr for this (rain mode is bad because they will use on rain) , is not the good way , rather you should talk with @JF002 so he talk to the pine64 team so they change the product page!
and even if at the very end @FintasticMan don't wan't to change the title , no one can't forbid you other than jf002 , once it's merged and before the release to change the setting name from "rain mode" to screen lock mode
Concern about water is not misplaced here. It's not my problem if people use the watch in water, but if InfiniTime had a feature related to water, we would partially be to blame for broken watches for endorsing it. Why would we have a feature that probably ends up breaking your watch?
I probably won't approve this. I'd rather see a new PR that has been designed from the ground up to fix existing issues and with convincing arguments as to why it is the best solution.
This pr isn't finished, I haven't had time to work on it.
I do understand that calling it rain mode is not a good idea, and I'd be more than happy to change it. I don't think that screen lock is a good term, as while that is what is doing, I think people understand screen lock to mean that it would need something like a PIN code to unlock. Maybe something as simple as just saying it disables touchscreen is good enough?
I do also think that this might not be an optimal solution for the problem. If someone has a better one, please mention it!
There's a lot going on here, let me try to re-focus the discussion.
Regarding the IP67 rating and the product page : Pine64 sells the hardware and not the software. The hardware is certified with IP67 rating, and there is nothing to change on the product page. I am totally not an expert in IP ratings, but I'm not sure that "protected against short periods of immersion in water while under pressure under 15cm and 1m" means that you can use and operate the watch while under 1m of water (or that it will work at all), or under jets of hot and soapy water from the shower, or under the pressure of moving water when you're swimming with your watch on your wrist. If you have concerns or questions about the IP rating of the PineTime, I would suggest you ask your question directly to Pine64, as the software has nothing to do with that.
By reading the comments in this discussions, I notice that you all have various and specific use cases : use the watch under heavy rain, while walking in the mountains, control the music under the shower, put the watch in your jean pocket with a lot of other pieces and objects in the pocket, use the watch while doing heavy activities. All these use-cases are probably valid but... I'm not sure we'll be able to implement the specific functionalities to support all of them. We are talking about a 25$ watch that is running on very constrained resources and not about a high-end device specifically built to resist to extreme environments and usages.
I do very little sport, I rarely have the opportunity to walk in the mountains under heavy rain and I always remove my watch when going to the pool and in the shower, so I might not fully understand your requests. But to me, it seems that the "lock screen" or "rain mode" or "shower mode" feature is trying to work around other issues : the touch panel is too sensitive (and is triggered by a small drop of water) and the rise/shake wake algorithm are too sensitive and wake the watch too often.
So I think we should try to fix those issues before trying to implement various complex algorithms to work around them.
the touch panel is too sensitive (and is triggered by a small drop of water)
So I think we should try to fix those issues before trying to implement various complex algorithms to work around them.
I thinking that this pr resolve this issue without complex algorithm , so it's good for the use case of sensitivity issue with the simple way : disable the touchscreen
any other way or fix would need to create complex algorithms to work around /fix the sensitivity for all use case.... that you seem don't want @JF002 .
(example : @hubmartin created a pr for screen brightness levels but it was never merged , even thought it was final, because it seem it was too complex but fixed the issue of brightness properly )
I believe that while the touchscreen in general might need some tuning to avoid ghost touches, I don't think it's likely or even possible to tune it in such a way that it doesn't register rain as touch inputs. I made this PR as it's an issue I face, and this solution is one I've seen used in other smartwatches (see this article from Samsung).
https://support.apple.com/en-us/HT210931 Same feature is also avaiable in apple watch, i agree with comment above.
@hellojaccc and @FintasticMan yours example are not good/relevant because , the pinetime is not able to go inside 50 m of water unlike apple and samsung watch
by the way , @Riksu9000 , i have the banglej2 , that have the same ip and form factor than the pinetime and there is a auto lock /disable touch screen functionality (that is disabled with long press of button) that exist and enabled by default
@Riksu9000 .. When exercising long (sweaty) sleeves touch the screen and mess all the settings on my PT ... Locking screen is MUST HAVE feature for folks who wear PT in the gym ...
There are multiple ways to tackle an issue. The most obvious ways may not be the best ways. It has already been mentioned here that we would rather tune the touchscreen first to reduce this issue. Wouldn't it be even better if you didn't even need to lock the device, and it just worked? #1011
(We're not saying deal with it, we're saying we may be able to do even better.)
There are multiple ways to tackle an issue. The most obvious ways may not be the best ways. It has already been mentioned here that we would rather tune the touchscreen first to reduce this issue. Wouldn't it be even better if you didn't even need to lock the device, and it just worked? #1011
(We're not saying deal with it, we're saying we may be able to do even better.)
@Riksu9000 sometime a good intention aka in your case tuning the touch for all case (https://github.com/InfiniTimeOrg/InfiniTime/issues/1011) is not the proper way because instead a simply disabling a the touch screen (but not the screen !) that by it's very nature is causing problem when touched , regardless of type of touch (a sleeve , a a key or whatever **can ** do long/little touch that you can't predict!)
you want to create an all purpose functionality , a labyrinth, the fine tuning task that would 'magicaly' address all case ! but
- first it will never be able to resolve the original problem (because it's unpredictable)
- second it will create by it very nature , unlimited of problem that would make it unable to be usable on some case that would need 'ironically' a feature to disable the touch screen ...
- trying to figure all case , all the time (so even when screen off!) will drain the pinetime way faster, because it's not a smartphone, making the purpose moot !!!
i would want to have @JF002 , or @Avamander or other to give a way, as well, because i think it's not resolvable with anything but with a feature to disable the touchscreen
disabling touchscreen would be an overkill - instead just disable navigating from main screen to various submenus/settings and display lock icon in the center (optional) ... This is typical behavior that I observed in other products that I owned in the past.
(In my case when I accidentally touch my PT multiple times w/o noticing I end up navigating into various menus and changing settings ... )
disabling touchscreen would be an overkill - instead just disable navigating from main screen to various submenus/settings and display lock icon in the center (optional) ... This is typical behavior that I observed in other products that I owned in the past.
(In my case when I accidentally touch my PT multiple times w/o noticing I end up navigating into various menus and changing settings ... )
@shvechkov which products are you talking about?
@trman garmin watches (e.g. vivoactive 3) , MSFT band (rip) ... Here is video: https://www.youtube.com/watch?v=Dpk2vM7KtZA&ab_channel=MrPerfect
On fitbits you have screen pin lock : https://www.youtube.com/watch?v=3wDP_GcQPj8&ab_channel=FoxyTechTips
@shvechkov i think you understand , but the first product is watch with far more processing power than pinetime and more battery and because of these functionality they last at best 3 day ....
i repeat , a functionality that drain the pinetime to make it last 3 day , because of its processing power needed make the purpose moot...
the second is screen with lock that may resolve the changing setting but would not resolve drain problem , because , the pinetime would show the pin screen every time it touched and thus draining the battery as well....
these example show , that for the draing battery issue related to the screen , this pull is far better...