InfiniTime icon indicating copy to clipboard operation
InfiniTime copied to clipboard

Pride flag watchface

Open Aperture32GLaDOS opened this issue 1 year ago • 38 comments

Adds a new watch face with the trans flag as a background

Features

  • A new watch face, featuring the mlm, trans, bi, and wlw flags
  • Bluetooth indicator in the top right
  • Long day names

Images

image image image image

Aperture32GLaDOS avatar Dec 16 '24 17:12 Aperture32GLaDOS

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed

github-actions[bot] avatar Dec 16 '24 17:12 github-actions[bot]

Love it! 🏳️‍⚧️😁 You are a very cool person, I'm going to be using this for a while!

Edit to add: I hope you find $20 on the ground or something similar fortunate and nice happens to you!

IMG_20241229_213604426~2

marigoldfish avatar Dec 30 '24 14:12 marigoldfish

Thanks for the quick feedback! I've implemented those changes, hopefully everything's good now

Aperture32GLaDOS avatar Dec 30 '24 18:12 Aperture32GLaDOS

All looks good to me! You couldn't have made review easier :)

I haven't had the chance to test on hardware yet and am away for now, but I should be able to test within a couple weeks time

mark9064 avatar Jan 03 '25 23:01 mark9064

I have been using this daily, and I really like it, but I have a few small suggestions:

I adore the "You have mail." for notifications, but I dislike that it overlaps so severely with the battery percentage:

IMG_20241231_082654043~2

I think it might look better to have "mail." on its own line below, and move "You have" up a little bit so they're both centered vertically in the blue stripe.

(The 90's kid in me really wants it to read "You've got mail," like AOL, but that's not a request for a change, just a nostalgic observation)

My other suggestion is to name the watch face more specifically as "Trans Flag" instead of just "Trans."

IMG_20250103_220544316_HDR~2

Like I said, very very small suggestions. The other 99% of this watchface is grand!

marigoldfish avatar Jan 04 '25 06:01 marigoldfish

I definitely agree with the notification and the name. Fortunately, these are just one-line fixes so it's not that hard to change. image

Aperture32GLaDOS avatar Jan 04 '25 11:01 Aperture32GLaDOS

Good spot, I'll fix that

Aperture32GLaDOS avatar Jan 04 '25 16:01 Aperture32GLaDOS

You are an incredibly awesome and speedy person! Thanks for implementing my suggestions, and so fast! I'll keep testing this daily for a while and let you know if I come across anything else 😁

marigoldfish avatar Jan 04 '25 16:01 marigoldfish

Hello again, I noticed another little thing after using this watch face for a while.

Usually I keep my watch in 24 hour time, but I had reason to use 12 hour time today, and I noticed that both AM and PM show up as "M."

(I manually set the watch to 2am to get the second picture, I didn't stay up late 😜)

IMG_20250117_184147295~2 IMG_20250117_184236513~3

marigoldfish avatar Jan 18 '25 02:01 marigoldfish

I think what's happening here is that the font used for the time doesn't have all the alphabet, if I change the font to something else it seems to work fine: image I've moved the AM/PM display to the day, since that uses a font which has all the alphabet image

Aperture32GLaDOS avatar Jan 18 '25 11:01 Aperture32GLaDOS

That's an elegant fix! I like it!

Unfortunately, in addition to praise I also come bearing news of a new bug: it is displaying 24-hour time when I have 12-hour time enabled.

IMG_20250119_203002810~2

marigoldfish avatar Jan 20 '25 04:01 marigoldfish

Aah, well at least that's an easy fix; it should all be working now image

Aperture32GLaDOS avatar Jan 20 '25 14:01 Aperture32GLaDOS

could you update to/rebase onto the latest main branch. The toolchain won't run as the artifacts v3 job was deprecated by GitHub, and that is fixen in the current main branch

NeroBurner avatar Feb 02 '25 21:02 NeroBurner

Yup, should be all good now

Aperture32GLaDOS avatar Feb 02 '25 21:02 Aperture32GLaDOS

Seems like this would wait for side loading. It may not fit the vision of "Only a minimal feature set in the flashed firmware". But, no biggy.

rdub1a4 avatar Feb 10 '25 06:02 rdub1a4

Seems like this would wait for side loading. It may not fit the vision of "Only a minimal feature set in the flashed firmware". But, no biggy.

I dont understand why this watchface was added to the 1.16.0 milestone so quickly over the various other watchface PRs that have been sitting around for quite a long time?

JustScott avatar Feb 10 '25 17:02 JustScott

Mainly because it doesn't depend on any other PRs and was easy to review

Things get added to the milestone when we want to target including them this cycle. If a PR depends on lots of other refactoring for example, or has outstanding bugs that are taking time to resolve, then it usually won't be queued up for the next cycle until it's ready. InfiniTime generally lacks reviewers though, so what gets queued and what doesn't depends on whether someone's had time to look at it properly

Edit: also you're totally welcome to help with review or express support/interest in PRs in the comments, it helps with prioritising review

mark9064 avatar Feb 10 '25 18:02 mark9064

Yeah, that makes sense - I've renamed all the WatchFaceTrans to WatchFaceTransFlag

Aperture32GLaDOS avatar Feb 15 '25 13:02 Aperture32GLaDOS

Wait why don't we use this as a general LGBTQ flag watchface? It would make the most sense to add all of the flags into the design if we already have the one. You can choose which one you want the same way you change the colors on the Infinineat watchface.

joseph58tech avatar Mar 23 '25 05:03 joseph58tech

I really like that idea! I've implemented four pride flags, (the classic rainbow, the existing trans flag design, the bi flag and the lesbian flag), and the switching seems to work fine

Aperture32GLaDOS avatar Mar 23 '25 12:03 Aperture32GLaDOS

image image image image

Aperture32GLaDOS avatar Mar 23 '25 12:03 Aperture32GLaDOS

Oops

Aperture32GLaDOS avatar Mar 23 '25 15:03 Aperture32GLaDOS

I have been using these new flag watchfaces for a while and have gotten several compliments from queer colleagues! I don't know if I have successfully convinced anyone to buy a Pinetime, but multiple people thought it was cool and wanted me to pass along their compliments. :rainbow_flag:

I do have some minor readability feedback after test driving these for a month. As usual for my feedback they are EXTREMELY minor, and mostly come down to my taste, so take 'em or leave 'em as you wish :stuck_out_tongue:

  • I feel like the bi flag would have better contrast if the time was white and the date/steps/battery were black.

  • I use the rainbow face the least, because the time is the least legible to me. I know this would make it inconsistent with the other faces, but it would be easier to see if the time were centered on the yellow stripe.

  • The time seems off-center vertically by a couple pixels or so. I wouldn't normally be nitpicky about something so small, but it's noticeable in the lesbian flag. Because the middle stripe is so narrow, the time aligns with the bottom but not the top.

marigoldfish avatar May 16 '25 03:05 marigoldfish

Thanks for the feedback! I definitely agree with your points - I've changed the time label's positioning (it's still not exactly center - it's an off by about half a pixel, but it's not really visibly wrong, even on the lesbian flag), and I've made it so that the bi flag has switched black and white text parts. I tried your suggestion with the rainbow flag, but I feel like what you gain in readability is lost in the formatting - I also tried using different colours for the time, but that didn't really help either. image image image

Aperture32GLaDOS avatar May 16 '25 13:05 Aperture32GLaDOS

When this is ready for review let me know ^^ All faces look finished to me visually other than the rainbow flag, the difference in lightness between the yellow and green definitely makes it hard... not sure I have any useful suggestions there Also, it'd be worth checking how the watchfaces look with AOD, if they looks odd it might be worth tweaking some colours a little to make the AOD presentation nicer

mark9064 avatar Jun 04 '25 15:06 mark9064

I have continued to "field test" these faces and I don't have any more feedback on appearance or alignment or whatnot. 👍🏻

I personally like the rainbow flag having the time entered on the yellow stripe, but I am willing to defer on matters of opinion. I have a rainbow watch strap so I'm more likely to use the trans or lesbian flag anyway.

That's a good point re AOD - I took a quick look while I was on the bus and they are quite different with it enabled (and I discovered a potential-bug in AOD that I'm going to investigate and write up separately if I can reproduce it). They show the time legibly, but the pride flags lose some of their distinction.

marigoldfish avatar Jun 04 '25 18:06 marigoldfish

I think for now it's easier to just remove the rainbow version - maybe in future I can figure out a way of making it look good. For now, I've replaced it with the mlm flag (it was also bugging me, I think if we have the wlw one we've gotta have the mlm one as well). image

Aperture32GLaDOS avatar Jun 16 '25 10:06 Aperture32GLaDOS

Sure, removing it for now until a better design is settled on makes sense.

For the mlm flag, should the text other than the time be white? Especially at the bottom the contrast looks quite poor

mark9064 avatar Jun 16 '25 13:06 mark9064

image I think I'm gonna have to have the text on top be black and the text on bottom be white

Aperture32GLaDOS avatar Jun 16 '25 13:06 Aperture32GLaDOS

image Yeah, that works quite well I think

Aperture32GLaDOS avatar Jun 16 '25 14:06 Aperture32GLaDOS