InfiniTime icon indicating copy to clipboard operation
InfiniTime copied to clipboard

Add shorter/simpler weather condition options.

Open JustScott opened this issue 1 year ago • 3 comments

These changes were originally created in PR #2001, but I'm spliiting them into their own PR as I believe they may be useful in other places and could be merged before the terminal watch face changes.

This change simply adds a GetSimpleCondition option as an alternative to GetCondition to return a shorter condition description. For example: returning 'Thunder' instead of 'Thunderstorm' as a way to save space in constrained areas without losing the original descriptions meaning.

There's an example GIF here of where this would be useful.

JustScott avatar Oct 03 '24 20:10 JustScott

Build size and comparison to main:

Section Size Difference
text 373040B 32B
data 948B 0B
bss 22536B 0B

Run in InfiniEmu

github-actions[bot] avatar Oct 03 '24 20:10 github-actions[bot]

@vkareh yes the short names are intended to be used for the weather info in the Terminal Watchface. See https://github.com/InfiniTimeOrg/InfiniTime/pull/2204

(I believe you already learned of it since your comment, but just for future readers to make this fact explicit)

NeroBurner avatar Feb 02 '25 21:02 NeroBurner

@JustScott sorry for taking ages to review!! If you're around to take a look at the review feedback that'd be super, hoping to get 1.16 out soon :)

mark9064 avatar Nov 09 '25 16:11 mark9064

I was looking into this to make the change myself since @JustScott does not seem available right now (which is not an issue at all :-) ). And to be honest, the change looks quite easy : replace "drizzle" by "showers" in Pinetime::Applications::Screens::Symbols::GetSimpleCondition() for the case "CloudSunRain". BUT in Pinetime::Applications::Screens::Symbols::GetCondition(), we simply used "Rain" for the case "CloudSunRain".

I'm not a native English speaker, and I struggle with those small nuances in the different words that represent "rain", but isn't this inconsistency between the 2 methods a bit confusing?

JF002 avatar Dec 26 '25 13:12 JF002

Change of mind from me: I completely missed the overall descriptions of the codes on the main table... oops

image

For this what makes sense to me is Clear (1,2) Cloudy (3,4) Showers Rain Thunder Snow Mist

I think Clear (1) and Cloudy (2,3,4) is reasonable too (maybe I'm an optimist when it comes to sun, but if it's mostly sunshine on the ground rather than shade then I'd lean towards clear)

mark9064 avatar Dec 28 '25 00:12 mark9064

I think Clear (1) and Cloudy (2,3,4) is reasonable too (maybe I'm an optimist when it comes to sun, but if it's mostly sunshine on the ground rather than shade then I'd lean towards clear)

I'm personally team Clear (1) and Cloudy (2,3,4). As soon as there's enough clouds in the sky for them to appear on the weather icon, I would no longer call that clear. I agree on the rest, tho :+1:

tituscmd avatar Dec 28 '25 00:12 tituscmd