InfiniTime icon indicating copy to clipboard operation
InfiniTime copied to clipboard

Watchface: add weather option to Casio style watchface

Open Ghoelian opened this issue 1 year ago • 20 comments

Adds the option to turn one of the segments on the Casio watchface into weather. InfiniSim_2024-08-04_230833 InfiniSim_2024-08-04_230835 InfiniSim_2024-08-04_230942

Ghoelian avatar Aug 04 '24 21:08 Ghoelian

Build size and comparison to main:

Section Size Difference
text 374692B 1604B
data 948B 0B
bss 22544B 8B

Run in InfiniEmu

github-actions[bot] avatar Aug 04 '24 21:08 github-actions[bot]

Das PR does not apply anymore due to the recent changes in the weather subsystem - would be cool to have this updated against the current state of main.

rnwgnr avatar Nov 21 '24 19:11 rnwgnr

Ah alright, I'll look into getting it updated when I get the time.

Ghoelian avatar Nov 21 '24 19:11 Ghoelian

I've updated my branch, seems to be working on my watch.

Ghoelian avatar Nov 21 '24 21:11 Ghoelian

Updated my watch and it works like a charm as it did before. Thanks.

Would be nice to see this included in 1.16.

rnwgnr avatar Nov 22 '24 18:11 rnwgnr

Would it be possible to choose which segment is replaced by weather? I made a hardcoded version of your idea as well a while back, but I replaced WeekNumber instead. If you could implement a way to choose which segment is replaced, we could essentially merge those ideas into one big PR. image

tituscmd avatar Nov 22 '24 19:11 tituscmd

Would it be possible to choose which segment is replaced by weather? I made a hardcoded version of your idea as well a while back, but I replaced WeekNumber instead. If you could implement a way to choose which segment is replaced, we could essentially merge those ideas into one big PR. image

Yeah I think I can do that, doesn't sound too difficult.

Ghoelian avatar Nov 22 '24 22:11 Ghoelian

For reference, I put the weather icon to align top left at 10, 22 and the temperature to align top left 45, 22 Feel free to just copy these or take them as a reference point for improving the looks of it.

tituscmd avatar Nov 22 '24 22:11 tituscmd

InfiniSim_2024-11-25_203125 InfiniSim_2024-11-25_203132

Added these two options.

Ghoelian avatar Nov 25 '24 20:11 Ghoelian

Oh I might even like that more than my approach! Good job, will definitely be using this, at least once 1.15 rolls out 😁

tituscmd avatar Nov 26 '24 06:11 tituscmd

For the segment that replaces the weeknumber, you should center the temperature and weather icon based on the weekday and offset them vertically (in the negative direction of course, since you're going up on the display).

Also, you merged something about notif vibration strength. I don't think you meant to put this into the PR.

Other than that, I'd love to have this in 1.16.0!

tituscmd avatar Dec 09 '24 00:12 tituscmd

Oops sorry yeah didn't mean to commit the vibration stuff to this branch, I'll fix that when I get the time.

Ghoelian avatar Dec 09 '24 08:12 Ghoelian

Oops sorry yeah didn't mean to commit the vibration stuff to this branch, I'll fix that when I get the time.

I came across this "accidental addition" and i really like it. Would be cool if you'd provide an additional PR for this.

rnwgnr avatar Dec 23 '24 19:12 rnwgnr

Sorry it took so long, but I've finally removed the unrelated commits. I'll get to fixing the alignment later!

Ghoelian avatar Jan 21 '25 18:01 Ghoelian

The merge box thingy is telling me one of the reasons merging is blocked because the branch "must not contain merge commits". Is this a real requirement for getting this merged?

Ghoelian avatar Jan 21 '25 18:01 Ghoelian

@rnwgnr created #2231 for the vibration settings

Ghoelian avatar Jan 21 '25 19:01 Ghoelian

Sorry it took so long, but I've finally removed the unrelated commits. I'll get to fixing the alignment later!

About the alignment, you can check my branch with the extremely long name of "1.15_ANCS_HR_CASIO_DGTL-W" where I think I nailed the alignment perfectly.

Here's a few pics: image image image

tituscmd avatar Jan 21 '25 19:01 tituscmd

I've been having some issues getting the simulator running on my setup (trying to run from a dev container), but I'll hopefully fix that and then this PR this weekend.

Ghoelian avatar Jan 24 '25 10:01 Ghoelian

@tituscmd I've fixed the alignment, looks a lot better now!

Ghoelian avatar Jan 26 '25 11:01 Ghoelian

Awesome! Glad to have been of help here 😄

tituscmd avatar Jan 26 '25 14:01 tituscmd