InfiniTime icon indicating copy to clipboard operation
InfiniTime copied to clipboard

DisplayApp: Go to clock on wakeup if no app loaded

Open vkareh opened this issue 1 year ago • 8 comments

When waking the screen up, if there is no actual app loaded (i.e. we are still in the QuickSettings, Settings, or Launcher screens) we should just reload the Clock app directly.

vkareh avatar Jan 18 '24 21:01 vkareh

Build size and comparison to main:

Section Size Difference
text 378868B 16B
data 948B 0B
bss 63488B 0B

github-actions[bot] avatar Jan 18 '24 21:01 github-actions[bot]

This supercedes https://github.com/InfiniTimeOrg/InfiniTime/pull/1436 since that one has conflicts and uses outdated function calls.

vkareh avatar Jan 18 '24 21:01 vkareh

Future compatibility thought: with always on display (#1869), it'd be preferred if the app was loaded on sleep entry rather than on wake. But the whole sleep state might end up being refactored anyway so if this is annoying to implement then don't worry

mark9064 avatar Jan 19 '24 20:01 mark9064

@mark9064 - that's a good point. I tried it on sleep and it works even better (the transition is less choppy). Thanks for the suggestion!

Regarding future refactor, I feel that this is a simple enough change and can be moved around as needed without much overhead.

vkareh avatar Jan 20 '24 04:01 vkareh

Great to hear it's working even better. To clarify what I meant originally: "as part of 1869, we might have to refactor some sleep stuff so if it's difficult to change this PR to work on sleep entry at the moment then don't worry". But you've managed to work it out anyway, so it doesn't matter :+1:

mark9064 avatar Jan 20 '24 16:01 mark9064

Finding this quite nice as I consistently forget to return to the watch face. I'm wondering what thoughts are on having this also apply to the notifications, as that isn't an app that really needs to stay open after you view it once.

JustScott avatar Jan 23 '24 00:01 JustScott

@JustScott at first I assumed that this wouldn't be necessary for the Notifications screen as I usually just dismiss notifications fairly quickly after viewing them, but then realized I use https://github.com/InfiniTimeOrg/InfiniTime/pull/1716 as part of my daily driver branch, so it's a bit less relevant.

However, after testing it some more, I think it makes sense to add Notifications to the list. It works well with it, so I've pushed a new change.

vkareh avatar Jan 23 '24 14:01 vkareh

Works great, don't find my watch on random screens where it has clicked itself nearly so often as all of the screens one swipe away now return back to the watchface safely. Integrates with AOD perfectly as well.

mark9064 avatar Apr 11 '24 21:04 mark9064

I noticed a small glitch when the watch wakes up and switches to the clock. Any idea was could be the cause of this?

https://github.com/user-attachments/assets/f7f4c4f8-d623-4c7b-80ba-62f0e02c124d

JF002 avatar Aug 19 '24 18:08 JF002

@JF002 no idea, but I notice it too. With the Always On option this works even better (and no glitch), but I suspect there's something happening in between turning the LCD off and loading the clock screen that keeps the previous screen in some transient store.

I wonder if a delay might help here... :thinking:

vkareh avatar Aug 20 '24 12:08 vkareh