InfiniTime icon indicating copy to clipboard operation
InfiniTime copied to clipboard
verified publisher icon InfiniTimeOrg

Setting to disable DFU and FS access

Open DavisNT opened this issue 2 years ago • 9 comments

This PR adds setting to disable firmware update and Bluetooth file transfer. This is 2. part for https://github.com/InfiniTimeOrg/InfiniTime/issues/1814#issuecomment-1763740314

DavisNT avatar Oct 20 '23 22:10 DavisNT

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed

github-actions[bot] avatar Oct 20 '23 22:10 github-actions[bot]

Both issues discovered by the workflows should now be fixed.

  • I have force-pushed fix for the formatting error in SettingOTA.cpp.
  • For InfiniSim I have created https://github.com/InfiniTimeOrg/InfiniSim/pull/125 Building this PR with InfiniSim PR should fix the InfiniSim build issue.

DavisNT avatar Oct 21 '23 21:10 DavisNT

The build-simulator step is expected to fail, because it needs https://github.com/InfiniTimeOrg/InfiniSim/pull/125

DavisNT avatar Oct 22 '23 14:10 DavisNT

Made two improvements:

  • Added branch prediction hints, to minimize performance impact during real data transfer
  • Return BLE_ATT_ERR_INSUFFICIENT_RES when access is not allowed

Could it be possible to review this PR?

DavisNT avatar Oct 27 '23 22:10 DavisNT

Rebased as well.

DavisNT avatar Oct 27 '23 22:10 DavisNT

Is this PR (and the other PR described in https://github.com/InfiniTimeOrg/InfiniTime/issues/1814#issuecomment-1763740314 ) welcome? If I will rebase and adjust this PR to work with the latest changes, will it be merged? @JF002, @FintasticMan, @Avamander Any feedback from project maintainers would be appreciated.

DavisNT avatar Jun 24 '24 17:06 DavisNT

Rebased (against main) and adjusted this PR. And done a few tests on my PineTime.

If there are questions about b2e2690adfbc13cbf4e0778a428baa6b11b35fba please see branch https://github.com/DavisNT/InfiniTime/tree/otaset-oom - this branch has the memory saving as the last commit (trying to build otaset-oom without last commit should cause the build to fail with /opt/gcc-arm-none-eabi-10.3-2021.10/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: region RAM overflowed with stack).

DavisNT avatar Jun 30 '24 18:06 DavisNT

Regarding https://github.com/InfiniTimeOrg/InfiniTime/pull/1891/commits/b2e2690adfbc13cbf4e0778a428baa6b11b35fba So one option is to decrease the heap size a notch so more RAM is free for static alloc. This is going to happen soon anyway as there are very few bytes free I'm not 100% sure why the original approach was taken, really @JF002 would have to chime in on this. I suspect that it's to ensure that classes only have access to certain controllers etc? The memory savings look good though

mark9064 avatar Jul 02 '24 22:07 mark9064